[Bug]: Nextcloud desktop client aborts sync in case of not enough space on disk without allowing to deselect folders

allexzander commented 2 years ago

⚠️ Before submitting, please verify the following: ⚠️

[X] This is a bug, not a question or a configuration issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct

Bug description

Nextcloud desktop client will abort the sync in case new files will not fit the remaining disk space and will not delete folders that are deselected in an attempt to free space locally.

Steps to reproduce

Sync some big files to a small partition (a few megabytes in size) such that there will be just 100-200MB of free space left
Upload some more big files to the server via the Web UI and force start the sync on the desktop client
Observe the error message about not enough space on the disk
Try to uncheck some big folders in the selective sync dialog in order to free up space on disk
Force start the sync and observe the desktop client is not removing unchecked folders as the sync is getting aborted because of not enough disk space error

Expected behavior

The desktop client should allow freeing up the disk space by blacklisting some big folders

Which files are affected by this bug

all

Operating system

Windows

Which version of the operating system you are running.

All

Package

Other

Nextcloud Server version

all

Nextcloud Desktop Client version

3.6.1

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

[ ] Default internal user-backend
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[X] Other

Nextcloud Server logs

No response

Additional info

No response

jospoortvliet commented 2 years ago

Tip for anyone who encounters this: from what I can tell (I tried), deletions of folders that have been deselected will not be synced to the server, so you can, after deselecting them, manually clean them so the sync can resume.

lckarssen commented 2 years ago

I can confirm this (unexpected) behaviour on Linux (Ubuntu 22.04).

daevidt commented 6 months ago

I can confirm this as well. Client version 3.12.3 (Linux).

nextcloud / desktop