[Bug]: UPDATE requires a REBOOT because stuck by Notepad/Firefox/Windows EXPLORER

bonac commented 1 year ago

⚠️ Before submitting, please verify the following: ⚠️

[X] This is a bug, not a question or a configuration issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct

Bug description

update is stuck because Firefox, Notepad and most important Windows Explorer are opened. This FORCES a reboot to update NextCloud Why do NextCloud updates ALWAYS requires a reboot. Having 100+ apps installed this is the app which is the more requiring reboot to be updated.

Steps to reproduce

launch Notepad and FireFox (Windows Explorer is always launched in the background)
download latest NextCloud version from https://nextcloud.com/install/ and update
There is a popup windows that either ask to will those app or wait for a reboot to allow update

Expected behavior

Not rely on other software to be able to update WITHOUT reboot.

Which files are affected by this bug

Irrelevant question as this bug deals with UPDATING NextCloud CLIENT.

Operating system

Windows

Which version of the operating system you are running.

Windows 10

Package

Official SNAP package

Nextcloud Server version

not relevant for this bug: local update trouble

Nextcloud Desktop Client version

Latest as of 2022-12-08 There is no way to get version from your GUI

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

[ ] Default internal user-backend
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Nextcloud Server logs

not relevant for this bug

Additional info

No response

r2evans commented 1 year ago

Similarly for me: Firefox, Thunderbird, and Windows Explorer. I have no nextcloud extensions in either of the first two, if I did then I would understand the need to close them out. Fortunately, it no longer "automatically" reboots after update (#4883 and #5252), but it still says that a system reboot is required. I still find it incredulous that when we have apps like Docker (relatively deep ties in the OS) that are able to update in-place without a need for reboot, why does the nextcloud desktop client? What is it about the client that cannot be updated without a reboot? You already force-close explorer.exe and restart it, what is is necessary?

Githopp192 commented 1 year ago

this is a old behave/bug .. happens since v.3.x.xx

Poikilos commented 1 month ago

Still occurs in 3.13.4.55824 with MSI auto-update on Windows 10 Home (Version 22H2)

sinni800 commented 3 weeks ago

It asks a total of three times nowadays. Gives the choice of reboot vs force close twice, and then after the setup, another reboot yes/no.

Even if you force close properly (and it doesnt restart the explorer after for bonus fun) it asks for the reboot anyway.

It also funny enough does the auto update only after booting up, which makes it even more incredibly annoying.

You start up your computer and the first thing that comes is that nice nextcloud update dialog. I think it's a major blowback because it induces so much annoyance at once.

nextcloud / desktop