Improve visuals in e2ee setup and usage

[nimishavijay]

While enabling and using end-to-end encryption, there are a few things that can be improved.

• It took me a second to find out that not all folders are synced as I immediately saw only the big green checkmark icon and missed the e2e infobox shown above it. What do you think about moving the e2e infobox from above the sync information to inside the sync information, just above the folders list?
• The background of the e2e infobox could be changed to yellow if e2e is not enabled to indicate a warning. We can also change the icon to the striked out lock that is used in the folders list.
• I'm also thinking that it makes sense to change the big green checkmark icon to a warning or error icon if e2e is not enabled as not all folders that have been added are synced. Would that be a bit much?
• If e2e is not enabled, the red striked out lock icon next to folder can be shown regardless of whether or not that folder is selected. And it can be green when e2e is enabled. I would also say that the "Could not decrypt" string can be removed because I missed it the first few times and I still understood the flow :)
• "Display mnemonic" --> "Show passphrase"
• "End-to-end encryption has been enabled for this account." (add full stop at the end of the sentence)

What do you think? :) cc @jancborchardt

Originally posted by @nimishavijay in https://github.com/nextcloud/desktop/issues/5258#issuecomment-1353004366

[claucambra]

• It took me a second to find out that not all folders are synced as I immediately saw only the big green checkmark icon and missed the e2e infobox shown above it. What do you think about moving the e2e infobox from above the sync information to inside the sync information, just above the folders list?

I'd be hesitant to do this as it is not strictly a sync error -- I think a notification (akin to what we are showing when big folders are found) is a better way to do this

• The background of the e2e infobox could be changed to yellow if e2e is not enabled to indicate a warning. We can also change the icon to the striked out lock that is used in the folders list.
• I'm also thinking that it makes sense to change the big green checkmark icon to a warning or error icon if e2e is not enabled as not all folders that have been added are synced. Would that be a bit much?

Icon change sounds good, but why provide a warning when it is possible the user is not interested in enabling E2EE? IMO we should only warn about things that are problematic and that the user needs to address (i.e. sync conflicts)

[nimishavijay]

why provide a warning when it is possible the user is not interested in enabling E2EE

I wasn't sure how important/problematic not having enabled e2ee is. My impression was that since the user may have initially selected a folder for syncing but it didn't sync would be confusing, it's kinda like a sync error, so showing a warning made sense. If this is more similar to the big folders message, then we could go ahead with a notification like you mentioned :) In case the notification is dismissed there should still be an option to set it up from the settings, so this infobox can stay where it is.

cc @jancborchardt when he's back

[jancborchardt]

@claucambra @nimishavijay agree with your conclusion :) infobox is fine, since indeed people might not be interested in end-to-end encryption.

[WuShufei]

I just compiled NC on ARMHF, and have no info box at all, nor any indication where to file my client keys. E2ee files are simply not downloaded, silently. The info box is inadequate as is.

[claucambra]

I just compiled NC on ARMHF, and have no info box at all, nor any indication where to file my client keys. E2ee files are simply not downloaded, silently. The info box is inadequate as is.

This is not a widespread issue and you are the only one reporting it, so I would suggest you look into how you have compiled the client and where this could be going wrong for you. (Do you have KMessageWidget?)