[Bug]: Virtual files thumbnails not working

ParisGreen commented 1 year ago

⚠️ Before submitting, please verify the following: ⚠️

[x] This is a bug, not a question or a configuration issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct

Bug description

virtual files aren't showing thumbnails, even on files available locally

Steps to reproduce

Enable Virtual Files on windows

Expected behavior

Virtual files include thumbnails

Which files are affected by this bug

birdie.jpg

Operating system

Windows

Which version of the operating system you are running.

10

Package

Appimage

Nextcloud Server version

24.0.5.1

Nextcloud Desktop Client version

3.6.4

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

[x] Default internal user-backend
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Nextcloud Server logs

No response

Additional info

Screenshot 2022-12-30 16 42 41 I'm not sure if this is a bug or if I set something up wrong, but I'm not seeing previews for virtual files anymore, even if they're saved locally. I could swear this wasn't the case previously, and it's a bit inconvenient to boot.

ParisGreen commented 1 year ago

Screenshot 2022-12-30 22 41 59 Just for reference, I tried reverting to client 3.5.2 and it behaves the way I'd expect with thumbnails. Hopefully that at least confirms it's a bug, and not user error.

Moosetracks555 commented 1 year ago

If you copy a file that has a thumbnail into a nextcloud directory the thumbnail shows in the nextcloud directory until the file is synced. As soon as the file syncs the thumbnail goes to a white page. Has anyone found a work around for this?

Leinad4Mind commented 1 year ago

Any news? Same problem here. Very annoying.

wonx commented 1 year ago

I am also experiencing this bug.

3dK commented 1 year ago

Same here with Version 3.9.0 (Windows). Image thumbnails not showing, but showing for video files.

sachz19 commented 1 year ago

Hi, experiencing the same issue on multiple clients on the latest agent version.

git-kick commented 1 year ago

+1 would greatly appreciate to see that one solved.

PW87 commented 11 months ago

I´ve the same problem. I´m using Version 3.10.0 (Windows - enable support for virtual files). When I open a folder with imagefiles, I can see all the thumbnails first. A few seconds later the thumbnails disappear one by one. I hope the issue could be fixed soon.

PhilippSchlesinger commented 11 months ago

I confirm the same problem as described above by the reporter and those who commented. I may be able to provide you with a workaround and an approach to the issue below.

In search of the root of the problem, I tried other steps first:

I removed the relevant sync folder in the Nextcloud client and added it again. This completely recreated the placeholder files. There was no change to the thumbnails issue.
I cleared the thumbnail cache as described at https://www.tenforums.com/tutorials/5655-clear-reset-thumbnail-cache-windows-10-a.html. This also resulted in no change to the thumbnails
I have reinstalled the latest release of the Nextcloud client under the user account in question. After the final necessary reboot and login, the thumbnails suddenly appeared, both for hydrated and for dehydrated files. But this is still not the answer to the problem.

Upon further testing I came to the following conclusion:

If there are multiple user accounts on the Windows system, thumbnails will be displayed in the account where the first login occurs. If there is a logout on the first user account, thumbnails will be displayed correctly after logging in again on the second account. If a second account is logged in parallel to the first, no thumbnails will be displayed there. If there is a logout on the first user account, thumbnails will be displayed correctly after logging out and in again on the second account.

PhilippSchlesinger commented 11 months ago

An additional note: It is sufficient to ensure that only one instance of Nextcloud is running at the same time on a Windows system. Therefore, if you close the Nextcloud Client on a Windows account and then start the Nextcloud Client on a different account, the display of thumbnails will work there. (I could reproduce the issue on at least different Windows systems)

@ParisGreen, @PW87, @git-kick, @sachz19, @3dK, @wonx and others who confirmed that bug: could you please test and report back if that is a workaround for you?

@allexzander, @mgallien Does the issue relate to the way in which the thumbnail provider shell extension registers itself with Windows Explorer?

sachz19 commented 11 months ago

Hi,

All systems I had the issue with only have a single user known on the system. No other users running in the background. Since updating it has fixed itself on my system, I still have to check the other systems to see if the issue is resolved after updating, due to holiday I haven’t had the time yet to check.

Thanks for the thorough investigation!

From: PhilippSchlesinger @.> Sent: donderdag 19 oktober 2023 12:29 To: nextcloud/desktop @.> Cc: sachz19 @.>; Mention @.> Subject: Re: [nextcloud/desktop] [Bug]: Virtual files thumbnails not working (Issue #5301)

An additional note: It is sufficient to ensure that only one instance of Nextcloud is running at the same time on a Windows system. Therefore, if you close the Nextcloud Client on a Windows account and then start the Nextcloud Client on a different account, the display of thumbnails will work there. @ParisGreen https://github.com/ParisGreen , @PW87 https://github.com/PW87 , @git-kick https://github.com/git-kick , @sachz19 https://github.com/sachz19 , @3dK https://github.com/3dK , @wonx https://github.com/wonx and others who confirmed that bug: could you please test and report back if that is a workaround for you?

@allexzander https://github.com/allexzander , @mgallien https://github.com/mgallien Does the issue relate to the way in which the thumbnail provider shell extension registers itself with Windows Explorer?

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/desktop/issues/5301#issuecomment-1770527884 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AXLUW3BAARUNOJNVDPQUK63YAD6ITAVCNFSM6AAAAAATNFULECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZQGUZDOOBYGQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AXLUW3GODJEALXG7SHNFFNLYAD6ITA5CNFSM6AAAAAATNFULECWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTJRAOIY.gif Message ID: @. @.> >

git-kick commented 11 months ago

Thanks for following this up.

Unfortunately, I cannot confirm PhilippSchlesingers observations:

I restarted my PC
logged in with my account (only)
made sure only 1 Nextcloud instance is running but thumbnails disappear (after showing up for a very short time after opening Windows Explorer)

In general, I have a single user PC which has been showing the problem for months.

PhilippSchlesinger commented 11 months ago

@git-kick did you try removing and re-adding your sync folder?

git-kick commented 11 months ago

@git-kick did you try removing and re-adding your sync folder?

No. Should I? Your yesterday's post suggests this doesn't help.

PhilippSchlesinger commented 11 months ago

No. Should I? Your yesterday's post suggests this doesn't help.

It did not help in my case. If you see this problem for a long time in a single user environment I would suggest to try to make a folder available locally via context menu "Always keep on this device". Maybe you can see thumbnails after this. Then you can try context menu "Free up space" and it should load thumbnails from the Nextcloud server afterwards. If this does not help, maybe re-adding the sync folder cleans up things, but this is just a suggestion.

git-kick commented 11 months ago

OK, after re-adding the folder with "virtual files"=off, I can see thumbnails on my machine.

So it seems I have a work-around, thanks @PhilippSchlesinger

PhilippSchlesinger commented 11 months ago

OK, after re-adding the folder with "virtual files"=off, I can see thumbnails on my machine.

Ok, this really should work after all, as with any other local folder on a Windows system. I intended to recommend re-adding the synchronisation folder with virtual files enabled just to set it up clean and fresh.

PhilippSchlesinger commented 10 months ago

@Leinad4Mind @Moosetracks555 @ParisGreen and others who confirmed that bug: Does someone have a similar scenario like described in https://github.com/nextcloud/desktop/issues/5301#issuecomment-1768009683 and https://github.com/nextcloud/desktop/issues/5301#issuecomment-1770527884?

If it holds true, please check if you can reproduce the corresponding similar issue https://github.com/nextcloud/desktop/issues/6145 as well. Thanks!

lordyavin commented 8 months ago

Just wanted to bump this up. Discovered the issue with windows client version 3.11.0stable-Win64 (build 20231211). I disabled the support of virtual files to get working thumbnails back. This is major for me when working with photo folders.

Update: I have two folders synced for different nextcloud accounts. I believe I had to disable virtual files for both.

virtualbitzz commented 8 months ago

there is a logout on the first user account, thumbnails will be displayed correctly after logging in again on the second account. If a second account is logged in parallel to the first, no thumbnails will be displayed there. If there is a logout on the first user account, thumbnails will be displayed correctly after logging out and in again on the second account.

I'm running the same version and am having the same issue

virtualbitzz commented 8 months ago

@Leinad4Mind @Moosetracks555 @ParisGreen and others who confirmed that bug: Does someone have a similar scenario like described in #5301 (comment) and #5301 (comment)?

If it holds true, please check if you can reproduce the corresponding similar issue #6145 as well. Thanks!

I'm on a single user system. This issue affects all users on my server, who also use single user systems.

PhilippSchlesinger commented 8 months ago

I'm on a single user system. This issue affects all users on my server, who also use single user systems.

Are preview images (thumbnails) enabled on the server? Do the users on your server see preview images in the Nextcloud web interface? With virtual files enabled, thumbnails are generated on the server.

MichaelLeenheer commented 8 months ago

Windows 11, only one NextCloud account on my system and having this same issue for a long time now.

A behavior I wanted to add to the conversation is that the thumbnails DO appear, but only for a moment. When I open a locally synced folder in Windows Explorer it displays the thumbnails, then goes through the folder one by one removing them. If I switch to another folder and back again, I can once again see the thumbnails for a moment before the same procedure happens again.

Possibly unhelpful but related data: The photos are almost all JPG files, from 3 to 7 MB. Image metadata changes seem to be a major cause of sync issues for me, especially if I let Lightroom automatically apply changes. Not sure if that's related or helpful at all.

lordyavin commented 8 months ago

thumbnails DO appear, but only for a moment.

The same for me on windows 10. At least before I disabled the virtual files.

virtualbitzz commented 8 months ago

I'm on a single user system. This issue affects all users on my server, who also use single user systems.

Are preview images (thumbnails) enabled on the server? Do the users on your server see preview images in the Nextcloud web interface? With virtual files enabled, thumbnails are generated on the server.

Yes previews work great on the server

PhilippSchlesinger commented 8 months ago

@virtualbitzz @lordyavin @MichaelLeenheer: could you please check if you can reproduce the corresponding similar issue https://github.com/nextcloud/desktop/issues/6145? Thumbnails and overlay icons are both provided by shell extensions and maybe there is a common root for this issue.

virtualbitzz commented 8 months ago

@virtualbitzz @lordyavin @MichaelLeenheer: could you please check if you can reproduce the corresponding similar issue #6145? Thumbnails and overlay icons are both provided by shell extensions and maybe there is a common root for this issue.

I will do some additional testing, however the rest of the shell extension appears to be functioning normally. I see proper icons for virtual files vs locally available files (blue arrows vs green check mark), the nextcloud menu when right clicking on a file or folder all works properly (sharing, copying links, etc.)

With #6145 the entire shell extension appears to not function properly for all but one user on a multi-user system. This is not the case for me. The shell extension works flawlessly, with the exception of file previews.

virtualbitzz commented 8 months ago

One additional note, it's my understanding that Nextcloud uses the same shell integration technique as onedrive. I attempted the same procedure with OneDrive (copying the image file to one drive, and clicking 'free up space'). The image preview is displayed properly in Onedrive.

lordyavin commented 8 months ago

Sorry, I did not test anything yet. Have it on my backlog but it's not of high priority for me. Disabled virtual files (real files) are okay for me at the moment. I will leave a comment if I have something to report. Thanks for your efforts.

PhilippSchlesinger commented 2 months ago

@MichaelLeenheer Do have more than one windows account logged in at the same time? Then please check if you have a similar scenario like described in https://github.com/nextcloud/desktop/issues/5301#issuecomment-1768009683 and https://github.com/nextcloud/desktop/issues/5301#issuecomment-1770527884?

MichaelLeenheer commented 2 months ago

No, in my case I have (had) only one Windows account on the computer.

I now have 2 accounts on this computer, but only one is logged in. Your email made me look again and hey presto! the thumbnails are working. So there does seem to be a link there ...

Michael

On Tuesday, July 2, 2024 at 04:41:04 AM MDT, PhilippSchlesinger ***@***.***> wrote:

@MichaelLeenheer Do have more than one windows account logged in at the same time? Then please check if you have a similar scenario like described in #5301 (comment) and #5301 (comment)?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

PhilippSchlesinger commented 2 months ago

@MichaelLeenheer Is one or are both of those accounts admin accounts? Are thumbnails working in both windows accounts at the same time (both accounts logged in in parallel)?

Could you please also check if you can reproduce this corresponding issue https://github.com/nextcloud/desktop/issues/6145?

Thank you.

nextcloud / desktop