nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.07k stars 804 forks source link

[Bug]: Fulltext search result links are wrong #6173

Open arnowelzel opened 1 year ago

arnowelzel commented 1 year ago

⚠️ Before submitting, please verify the following: ⚠️

Bug description

When doing a fulltext search in the client, the links to documents are generated like this:

https://server.example/apps/files/%3Fdir=/some/folder/&scrollto=somefile.pdf

However, the escaping "%3F" is wrong. This must be "?":

https://server.example/apps/files/?dir=/some/folder/&scrollto=somefile.pdf

Steps to reproduce

  1. Search for a file with the Nextcloud desktop client
  2. Click on one of the found files within the "Full Text Search" result
  3. See the link in the browser which contains "%3F" instead of "?"

image

image

Expected behavior

The result link contains "/apps/files?dir=" and not "/apps/files%3Fdir=".

Which files are affected by this bug

not relevant, affects every search result

Operating system

Windows

Which version of the operating system you are running.

Windows 10

Package

Appimage

Nextcloud Server version

27.1.2, 27.1.3, 28.0.0, 28.0.1

Nextcloud Desktop Client version

3.10.0, 3.10.1, 3.11.0

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

Nextcloud Server logs

No response

Additional info

No response

hartsberger commented 5 months ago

We encounter the exact same issue as we want to enable full text search.

It is still present with this versions:

Nextcloud Server version: 27.1.10 Nextcloud Desktop Client version: Windows 3.13.0 Full text search: 27.0.3 Full text search - Elasticsearch Platform: 27.0.6 Full text search - Files: 27.0.1 Full text search - Files - Tesseract OCR: 27.0.0

But the Tesseract OCR app should not make any difference. I have testet it with and without it and it was reproducable.

2024-06-14 07_03_36-Nextcloud

Here is the bug archive of the client: fulltextsearch_bug.zip

In this case, I searched for "fullindexsearchexcel". (Hope that helps)

Or is this more related to the fulltextsearch app? Then I would create an issue there, too.