search

nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
2.91k stars 773 forks source link

🛎️ 🔄️ Improve notifications of file changes from notify_push server app #6430

Open mgallien opened 5 months ago

mgallien commented 5 months ago

Currently desktop client will register to notification from server for changes to files to immediately synchronize changes instead of polling for them. In case we receive a notification, desktop client will need to discover them. It would be better to register for notifications with more information (using listen notify_file_id). Most of the time that would give more information to desktop files client being able to then shortcut the sync and do it quicker and using less server resources.

mgallien commented 5 months ago

@AndyScherzinger @tobiasKaminsky

marcotrevisan commented 5 months ago

Just linking related issues to this one: #5072, https://github.com/nextcloud/notify_push/issues/192

marcotrevisan commented 5 months ago

By the way I didn't fully understand the HPB related comments in #5072, and after all in my humble opinion, the client should not need further pieces of server architecture to work properly with push notifications...

AndyScherzinger commented 5 months ago

@marcotrevisan there won't be any further server pieces here. The HPB can supply further details on changes files/folders which would improve the sync logic on the client not having to create the number of profinds it does today.