Bugfix nextcloudcmd when syncing results in deleting all files

nextcloud / desktop

💻 Desktop sync client for Nextcloud

https://nextcloud.com/install/#install-clients

GNU General Public License v2.0

2.89k stars 772 forks source link

Bugfix nextcloudcmd when syncing results in deleting all files #6773

Closed camilasan closed 2 days ago

camilasan commented 1 month ago

Fix for https://github.com/nextcloud/desktop/issues/3144
Makes warning more concise:
- warning when deleting all files in the server
- before:
- after:
- warning when deleting all local files
- before:
- after:

camilasan commented 3 weeks ago

I tested the code as it is without having ever manually modified the setting promptDeleteAllFiles so default value (false) kicks in and we get no popup in nextcloud graphical full sync client and cmdlightweight client is not getting stuck if you change the value to true I get the improved popup in the graphical client but the command line one will get stuck again

I know and I tried to decouple the 2 things (the sync trigger from cmd and the notification when using the UI) but I couldn't think of a good of doing that.

camilasan commented 4 days ago

/backport to stable-3.13

nextcloud-desktop-bot commented 2 days ago

AppImage file: nextcloud-PR-6773-92390cc754f819e27228a6eb0c6fecbb9c2fab7c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarcloud[bot] commented 2 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud