Fix "The host name did not match any of the valid hosts for this certificate" notification even when the certificate was valid

nextcloud / desktop

💻 Desktop sync client for Nextcloud

https://nextcloud.com/install/#install-clients

GNU General Public License v2.0

2.89k stars 772 forks source link

Open camilasan opened 1 month ago

camilasan commented 1 month ago

I am trying to solve this: the client was complaining about invalid certificates even though the certificate was valid with "The host name did not match any of the valid hosts for this certificate"
I only could reproduce what was reported with stable-3.13 and Qt 5 on Linux.
We might have hit a Qt5 bug, but I couldn't find reports.
The issue was gone once the setting of ssl options were removed in https://github.com/nextcloud/desktop/commit/52996774b588b3bba9d99d9d18a3e7c41a421a33.

sonarcloud[bot] commented 1 week ago

Failed conditions
2 New Code Smells (required ≤ 0)

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

nextcloud-desktop-bot commented 1 week ago

AppImage file: nextcloud-PR-6785-592ef1c813fbd5f82480e9f639d1ee6677bd592f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.