nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
2.89k stars 771 forks source link

Allow deletion of virtual suffix placeholder files #6821

Closed claucambra closed 16 hours ago

claucambra commented 1 week ago

Preventing their deletion is a more confusing and counterintuitive behaviour

camilasan commented 3 days ago

Would make sense to test add a test for this?

claucambra commented 3 days ago

Would make sense to test add a test for this?

I amended the existing test

claucambra commented 3 days ago

Looking at the test I need to make a couple more small changes

claucambra commented 3 days ago

Now fixed

mgallien commented 16 hours ago

/backport to stable-3.13

nextcloud-desktop-bot commented 16 hours ago

AppImage file: nextcloud-PR-6821-2915e2517e26e2793c445d93341d37cedd5a9e6a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarcloud[bot] commented 14 hours ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud