nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
2.97k stars 781 forks source link

[Bug]: Nextcloud deletes `.~lock` files from Libroffice #6957

Open derspotter opened 1 month ago

derspotter commented 1 month ago

⚠️ This issue respects the following points: ⚠️

Bug description

Nextcloud simply deletes with no warning any .~lock.*.odt files that Libroffice creates in order to prevent data loss when your computer turns off without saving the file. This has caused me great pain. I specifically installed nextcloud in order to not experience file loss and now it is nextcloud causing it!

Steps to reproduce

  1. Write inside a libroffice .odt file
  2. turn off your computer without saving the file (battery empty, fast shutdown)
  3. when nextcloud syncs, it deletes the .~lock recovery file, so no recovery possible

Expected behavior

Nextcloud should at least not delete the file even if it does not sync it, better even it syncs the file.

Installation method

Official All-in-One appliance

Nextcloud Server version

master

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

solracsf commented 1 month ago

Those files are in the exclude list. https://github.com/nextcloud/desktop/blob/c52b1e993318d29bbd9256ddd6cbd9a177b24ca1/sync-exclude.lst#L5

You can override that list in your client configuration. Check https://help.nextcloud.com if you need further assistance 👍

derspotter commented 1 month ago

I know, but they should not be. Why would one want to automatically delete a backup? This makes no sense at all. They should be removed by standard.

joshtrichards commented 1 week ago

I believe this is what the Allow deletion toggle option (in the Ignored Files* list) is intended for, but it is already off for .~lock files. :thinking

What client version, @derspotter?