automatically suspend synchronization of a disappeared group folder: avoid deleting currently synced files

nextcloud / desktop

💻 Desktop sync client for Nextcloud

https://nextcloud.com/install/#install-clients

GNU General Public License v2.0

2.97k stars 784 forks source link

automatically suspend synchronization of a disappeared group folder: avoid deleting currently synced files #7013

Open ferdiga opened 3 weeks ago

ferdiga commented 3 weeks ago

How to use GitHub

Please use the 👍 reaction to show that you want to have the same feature implemented.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.

Feature description

this proposed solution deleted all synced data of the group folders - some 150GB - in my case https://github.com/nextcloud/fulltextsearch/issues/858#issuecomment-2294889748

I suggest to check the size of the deleted files and propose to ask "Do you really want to delete xxxGB"

It's just the reverse situation of checking/asking if the client should download large directories.

mgallien commented 3 weeks ago

@ferdiga I do not get what you are asking for. Are you suggesting that under some conditions, files no longer available on the server must not be deleted by the sync client ? That would result in a subsequent upload by the client. If I understand the original problem correctly, the given user would now have a copy of the group folder in their own personal storage space. That may not be desirable.

Please note that for storage that may temporarily be unavailable, there is a way to handle this and in fact the client would pause the sync of a given folder that is reported as not mounted by the server.

Just being absent, will cause upload to your personal storage and I doubt that this is what most users would want.

mgallien commented 3 weeks ago

I took on me to rename the issue to not sound like a bug (especially since you added the enhancement label). When we speak about files being deleted, people tend to be over reactive.

ferdiga commented 3 weeks ago

what happened:

group folders have been disabled
client sync deleted immediately some 100GB, as group folders vanished
after enabling the group folders again some 100GB have been downloaded again. Was not a problem on high capacity connection

this is obviously a correct behaviour.

Nevertheless IMO the client should ask if the files should be deleted or if this is only temporary outage.

The problem seems that if no server is available, the sync is paused, but in this case the server was available.

joshtrichards commented 2 weeks ago

Related: #6099