nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.06k stars 804 forks source link

[Bug]: Various shades of grey in darkmode #7037

Open AndyScherzinger opened 3 months ago

AndyScherzinger commented 3 months ago

Might be on purpose, hence close if n/a

Sync tab Connection settings tab Settings win11 settings example
2024-08-27 17_01_54-NVIDIA GeForce Overlay 2024-08-27 17_02_04-NVIDIA GeForce Overlay 2024-08-27 17_02_25-Nextcloud-Einstellungen 2024-08-27 17_00_59-Einstellungen
2024-09-08 18_33_13- Bug _ Various shades of grey in darkmode · Issue #7037 · nextcloud_desktop – Mo 2024-09-08 18_26_49-NVIDIA GeForce Overlay 2024-09-08 18_31_34- Bug _ Various shades of grey in darkmode · Issue #7037 · nextcloud_desktop – Mo
mgallien commented 3 months ago

main dialog screenshot using more native styling with dark mode (Fusion qml style) image

set status image

this was done by using https://github.com/nextcloud/desktop/pull/6980 there is an issue with the Windows native QML style this style should look more native but is not working with dark mode I tried to fix this but that may be a lot of work

mgallien commented 3 months ago

I realized that current builds on Windows use "fusion" widget style for QWidget based dialogs with native style, I think we are already better image

please note that there is a double frame around the folder configuration area

mgallien commented 3 months ago

with better native style on Windows and a couple more small improvements image image image

AndyScherzinger commented 3 months ago

Nice improvements @mgallien 🤩

mgallien commented 3 months ago

I am unsure what to do with the QML user interfaces should we stay with Fusion non native but looking good in bright and dark mode ? should we go with native Windows style and spend a big effort trying to make it work in dark mode ?

I can provide bright mode screenshots to help

@AndyScherzinger @jancborchardt

mgallien commented 3 months ago

Fusion bright mode image

Windows bright mode image

jancborchardt commented 3 months ago

@mgallien we should always prefer to have it as native as possible on all platforms. In the 2 screenshots, besides some bugs in the Windows version that have to be fixed, there is almost no discernible difference, and both can look more native.

Another example in settings, the tabs don’t look like standard (more like 2 buttons?) and the line containers for settings groups look quite dated: image

mgallien commented 3 months ago

I will (but in the make UI more native PR) record a video. I would ping design team there. That should make differences more obvious.

Regarding the frames in the settings dialog, I need to investigate why they look so bad by default. I do not think we override or customize anything there.

mgallien commented 3 months ago

regarding the frames and generally the settings please have a look at the screenshots in https://github.com/nextcloud/desktop/pull/7051 I just forgot to left align a single label and fixed after the screenshots