[Bug]: Disabling existing folder sync makes notifications spawn continuously

Slater91 commented 1 month ago

⚠️ Before submitting, please verify the following: ⚠️

[X] This is a bug, not a question or a configuration issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct

Bug description

If you sync a folder to the local machine, then disable the synchronisation, the client keeps on spamming notifications about the fact that the folder exists locally, but that it isn't synchronised. While this can be useful if it happens once, when you start the client, it is actually repeated multiple times every single time the client connects to the network, which very quickly becomes annoying rather than informative.

The message reads as follows: "The folder [folder] was created but was excluded from synchronization previously. Data inside it will not be synchronized."

Steps to reproduce

Sync a remote folder to the local machine
Disable syncing without deleting the folder
Disconnect and re-connect to the network (e.g. by putting the computer to sleep and then waking it)

Expected behavior

The notification is only presented once, when the client is started.

Which files are affected by this bug

A folder.

Operating system

Linux

Which version of the operating system you are running.

KDE Neon (based on Ubuntu 22.04)

Package

Distro package manager

Nextcloud Server version

29.0.6

Nextcloud Desktop Client version

3.13.2

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Enabled

Are you using an external user-backend?

[ ] Default internal user-backend
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Nextcloud Server logs

No response

Additional info

No response

kcholoren commented 1 month ago

Same problem on Linux Mint 21.3, desktop client 3.14.0 version.

ChristophWurst commented 3 weeks ago

The notification itself seems old: https://github.com/nextcloud/desktop/commit/e65caee9cff1b6ad2515006d0e0f9761b3f5eccc

It must be a new(er) bug that this message shows.

In my scenario

Folder 1 (included in sync)
- Sub 1 (included in sync in the past, excluded from sync now)
- Sub 2 (included in sync)

I synced Sub 1 before. Whenever I save files in Sub 2 I get a notification that Sub 1 was created but won't be synced.

@mgallien you touched this area recently. Any ideas?

PhiCecHey commented 5 days ago

I have the exact same issue. Im using Tumbleweed, Gnome 47. This happens to both rpm and flatpak. It doesnt just happen when reconnected to the network, but in my case it happens every single time my client syncs and as far as i can tell I get this notification for every file that is in that folder. In my case, I sync my pictures in a folder called Pictures which also contains the Gnome Screenshots folder. I dont want to sync the screenshots I take across my devices, so the client spams me with the notification, that these files are excluded. My work-around is to delete the Screenshots folder on startup. It is incredibly annoying to the point where as an admin I install the flatpak app (without Nautilus Files integration, the nautilus Nextcloud extension only works for the rpm package) because then the app is sandboxed which allows me to mute all Nextcloud Desktop notifications. I really, really, desperately hope for a "mute all Nextcloud Desktop notifications" as well as a "mute 'files are not synchronized' " button, since I actually dont want to mute all notifications... So far there is only an option to mute calls or server notifications. I fail to understand why the not sandboxed Nextcloud Client installed via rpm doesnt respect the Gnome notification settings since other apps do. I would greatly appreciate such a setting. I absolutely love Nextcloud, I host my own server. This setting though is urgently necessary as those notifications makes the desktop client unusable if not used as flatpak. Thank you btw for all the work you guys put in, it is extraordinary how far this project has come.

nextcloud / desktop