nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.04k stars 799 forks source link

[Bug]: Windows client: upload fails if conaining folder has weird quotation marks #7149

Open kubrickfr opened 1 month ago

kubrickfr commented 1 month ago

⚠️ Before submitting, please verify the following: ⚠️

Bug description

I had an issue where a windows machine was trying to sync files from folders with sloped single quotation marks, for example:

Images that show single animals ‘moods’ e.g. meditating, looking out onto the open space etc (that's the name of the directory).

The client would show errors such as server is unable to maintain the header compression context, the server shows errors like

Expected filesize of 5927691 bytes but read (from Nextcloud client) and wrote (to Nextcloud storage) 1081344 bytes. Could either be a network problem on the sending side or a problem writing to the storage on the server side.
Expected filesize of 9559042 bytes but read (from Nextcloud client) and wrote (to Nextcloud storage) 1056768 bytes. Could either be a network problem on the sending side or a problem writing to the storage on the server side.
Expected filesize of 5705999 bytes but read (from Nextcloud client) and wrote (to Nextcloud storage) 1163264 bytes. Could either be a network problem on the sending side or a problem writing to the storage on the server side.

All with seemingly random sizes.

The Application logs shows errors like

Connection closed

Renaming the folder to remove the offending characters fixes the issue.

Steps to reproduce

Create folders with names like Images that show single animals ‘moods’ e.g. meditating, looking out onto the open space etc Put multiple files in it, some files fail to upload

Expected behavior

Files get uploaded properly

Which files are affected by this bug

Images that show single animals ‘moods’ e.g. meditating, looking out onto the open space etc

Operating system

Windows

Which version of the operating system you are running.

Windows 11 Home

Package

Official Windows MSI

Nextcloud Server version

29.0.7

Nextcloud Desktop Client version

3.14.0

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

Nextcloud Server logs

No response

Additional info

20240916_1858_nextcloud.log.0.gz

ted423 commented 1 month ago

Windwos Client I return to 3.13.3,some file new add show connection closed. I don't know if same issue

08:54:23||Hexo/ted423/.deploy_git/Document/Network/2magnet|8|1|1726415642||0|00302838oc4b126rtraz|13|未知错误|201|0|0|e23d6b67-29da-48bf-96dd-68ada1d5edbe|
08:54:23||Hexo/ted423/.deploy_git/Document/Encode/x265|8|1|1726415642||0|00302837oc4b126rtraz|13|未知错误|201|0|0|26287ab5-8b35-4249-950e-eec642f41911|
08:54:23||Hexo/ted423/.deploy_git/Document/Network/DNS|8|1|1726415642||0|00302839oc4b126rtraz|13|未知错误|201|0|0|ede03439-d52f-4d4e-940c-1c09f6f41299|
08:54:24||Hexo/ted423/.deploy_git/Document/Network/Windows-ip-route|8|1|1726415642||0|00302842oc4b126rtraz|13|未知错误|201|0|0|ce15a132-2ef4-4102-9134-f2515c7abb1b|
08:54:24||Hexo/ted423/.deploy_git/Document/Network/SSL|8|1|1726415642||0|00302841oc4b126rtraz|13|未知错误|201|0|0|9a5e2b5e-6065-40b0-b0de-eec2654930cd|
08:54:24||Hexo/ted423/.deploy_git/Document/Network/magnet|8|1|1726415642||0|00302843oc4b126rtraz|13|未知错误|201|0|0|61247a90-f6a0-4c25-8cd3-892be629f255|
08:54:24||Hexo/ted423/.deploy_git/Document/Network/IP|8|1|1726415642||0|00302840oc4b126rtraz|13|未知错误|201|0|0|c91a7582-1565-4f40-aad6-561254388c8a|
08:54:25||Hexo/ted423/.deploy_git/Document/Network/twitter|8|1|1726415642||0|00302845oc4b126rtraz|13|未知错误|201|0|0|66acf931-5320-4bc6-a24e-3aa6d6968c67|
08:54:25||Hexo/ted423/.deploy_git/Document/Network/telecom|8|1|1726415642||0|00302844oc4b126rtraz|13|未知错误|201|0|0|725370e6-ff11-4e00-a986-4dedae2233d7|
08:54:25||Hexo/ted423/.deploy_git/Document/madvr|8|1|1726415641||0|00302847oc4b126rtraz|13|未知错误|201|0|0|120d8c01-b575-4b16-8d68-880976d17be4|

like this

未知错误 -> Unknown error

Nextcloud Hub 8 (29.0.4)

mafmartins commented 1 month ago

I'm also experiencing this on the macos client version 3.14.0.

Directories with accents in it's name give the following error: server is unable to maintain the header compression context.

jggc commented 1 month ago

I have a similar issue with one of my clients running Nextcloud. He started experiencing it yesterday or today.

He upgraded the client about 2 days ago and noticed yesterday or today that none of his files or his teammates files are synced to his desktop anymore. His teammates and the server are fine, no sync problems.

He also installed the desktop iCloud client but it's working in a completely separate folder.

I'm leaning towards the same issue as here since in his logs ALL of the failing files/folders have special characters in them.

I cannot share the full file paths as they may contain confidential information but they look like this :

CAD/Rendu/CLIENT/Haute Qualité/img1.png
CAD/Rendu/CLIENT/Haute Qualité/img2.png
CAD/Rendu/CLIENT/Haute Qualité/img3.png
CAD/Rendu/CLIENT/Haute Qualité/img5.png
7000 - Préliminaire/Some folder name/Client Paul & Jûliö/Préfini.pdf

There are about 50 files in this situation, they all contain at least one of these characters é & ë

This prevents any file from syncing. He tried creating a file named potato at the root of his Nextcloud folder and it did not sync either.

He is running latest Windows Desktop Client and an older server version, 25.0.3 .

I will be upgrading the server up to 29 right now and report here if this helps but I doubt it as his colleague has no issue with the same file names.

Edit -- Server is upgraded, client is out of office for a few days, will report back.

andre-spindler commented 1 month ago

Same error here - also german umlauts are affected. Nextcloud Server is 29.0.5 (Hetzner Storage Share) Win Client ist 3.14.0 (latest).

Upload of files with umlaut in Filename worked at least on Aug 25th. Today it is broken.

Toastyyy3 commented 1 month ago

Same on MacOS 14.6.1, Nextcloud Server is 29.0.7, Nextcloud Client is 3.14.0. File name in question is "Rückblick.mov"

lovenemesis commented 1 month ago

Same error with if certain Chinese characters presents in file names.

Downgrade the Client to 3.13.4 fixed the problem.

Commifreak commented 1 month ago

Same here. Many issues with Connection closed Downgrade to 3.13.4 fixed the issue (Windows)

jrozanski commented 1 month ago

Confirmed. The 3.14.0 should be considered an invalid release.

nickvergessen commented 1 month ago

It seems to be caused by HTTP2 support. On Friday 3.14.1 was released disabling the new HTTP2 handling again and therefor fixing it.

kubrickfr commented 1 month ago

I hope this is a temporary fix right? I was hoping for HTTP3 support (only half joking).

The dev team seems to be spread so thin it's incredible.

nickvergessen commented 1 month ago

The dev team seems to be spread so thin

Good news, the client is open source and you can help diving into things.