[Bug]: Cannot stop self-updating the desktop client

ostasevych commented 1 month ago

⚠️ Before submitting, please verify the following: ⚠️

[x] This is a bug, not a question or a configuration issue.
[x] This issue is not already reported on Github (I've searched it).
[x] Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
[x] I agree to follow Nextcloud's Code of Conduct

Bug description

Hi! I have Win10x64.

I sincerely hate the recent update to 3.14.x, which is ugly and broken. So, I decided to switch off the desktop client from self-updating, by adding:

skipUpdateCheck=true key to the nextcloud.cfg config file
skipUpdateCheck=1 key to HKEY_LOCAL_MACHINE\Software\Policies\Nextcloud GmbH\Nextcloud
skipUpdateCheck=1 key to HKEY_LOCAL_MACHINE\Software\Wow6432Node\Nextcloud\Nextcloud

according to https://docs.nextcloud.com/desktop/latest/autoupdate.html

Every time after reboot the client ignored the key and self-updating without even noticing me. And I have to downgrade it manually.

What to do to stop it from self-updating and freeze the version which I like?

Steps to reproduce

Add keys to:

skipUpdateCheck=true key to the nextcloud.cfg config file
skipUpdateCheck=1 key to HKEY_LOCAL_MACHINE\Software\Policies\Nextcloud GmbH\Nextcloud
skipUpdateCheck=1 key to HKEY_LOCAL_MACHINE\Software\Wow6432Node\Nextcloud\Nextcloud Observe that after reboot of PC the desktop client is self-updating.

Expected behavior

The desktop client should NOT self-update after adding the keys. Moreover, it should ask whether I really want to update it, but not do it silently.

Which files are affected by this bug

n/a

Operating system

Windows

Which version of the operating system you are running.

Win10x64

Package

Official Windows MSI

Nextcloud Server version

28.0.10

Nextcloud Desktop Client version

3.13.4

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

[ ] Default internal user-backend
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Nextcloud Server logs

No response

Additional info

No response

FileNotFound7 commented 2 weeks ago

I found a workaround to this problem. In the same nextcloud.cfg file where you added the skipUpdateCheck=true line (mine was at C:\Users\USERNAME\AppData\Roaming\Nextcloud\nextcloud.cfg), find the section labeled [Updater] and rename the section to something like [donotuseUpdater]. This will stop the client from trying to update with the file that it already downloaded before you added the registry keys. Restart the client, and it should start silently without trying to update.

I think the change that should be made is to delete the downloaded update from the directory and from the config if the user had decided to disable updates.

ostasevych commented 2 weeks ago

donotuseUpdater

So, I will have in my nextcloud.cfg:

[General]
confirmExternalStorage=true
crashReporter=false
monoIcons=true
newBigFolderSizeLimit=500
optionalDesktopNotifications=true
useNewBigFolderSizeLimit=true
optionalServerNotifications=true
updateSegment=69
showInExplorerNavigationPane=true
clientVersion=3.13.4stable-Win64 (build 20240912)
showCallNotifications=false
isVfsEnabled=false
overrideLocalDir=
overrideServerUrl=
showExperimentalOptions=true
showMainDialogAsNormalWindow=true
moveToTrash=false
notifyExistingFoldersOverLimit=false
stopSyncingExistingFoldersOverLimit=false
launchOnSystemStartup=true
autoUpdateCheck=false
skipUpdateCheck=true
...
[donotuseUpdater]
autoUpdateAttempted=true

[Nextcloud]
autoUpdateCheck=false

Will it be enough to stop it from trying to self-update?

FileNotFound7 commented 2 weeks ago

I believe that should work however our issues might be different since mine had already downloaded an update before i'd set the registry keys. See if it works though, you can always revert the changes.

nextcloud / desktop