search

nextcloud / desktop

💻 Desktop sync client for Nextcloud
https://nextcloud.com/install/#install-clients
GNU General Public License v2.0
3.06k stars 804 forks source link

Fix login regression on linux #7455

Closed cmuck closed 17 hours ago

cmuck commented 2 weeks ago

Workaround for fixing https://github.com/nextcloud/desktop/issues/2573 and https://github.com/nextcloud/desktop/issues/7231

The workaround was introduced in 2022 by https://github.com/nextcloud/desktop/pull/4830 and recently (accidentally?) removed by https://github.com/nextcloud/desktop/pull/4584

camilasan commented 2 weeks ago

Possible fix for #103 and #7231

camilasan commented 2 weeks ago

/backport to stable-3.14

cmuck commented 1 week ago

@claucambra @mgallien @camilasan could you please review this PR?

cmuck commented 1 week ago

Awesome, thanks @claucambra , could you please give an approval to start the workflows too?

camilasan commented 4 days ago

@cmuck the AppImage is failing to build with:

+ appimagetool -n ./squashfs-root Nextcloud_Desktop-x86_64.AppImage
./admin/linux/build-appimage.sh: line 100: appimagetool: command not found
Rello commented 2 days ago

@cmuck do you have any capacity to look at it on short notice? we are planning the next release this week and are very interested to put this one in. let us know...

cmuck commented 1 day ago

I'm on it

camilasan commented 1 day ago

I'm on it

I am trying this https://github.com/nextcloud/desktop/actions/runs/11954739882/job/33325545335?pr=7543 see #7543

camilasan commented 1 day ago

@cmuck could you remove the merge commit and rebase it?

camilasan commented 1 day ago

@cmuck it is working now 🎉 thank you so much!

cmuck commented 1 day ago

Okay, the Linux AppImage Package job definitely worked, now failing with ...

2024-11-21T17:30:10.5097181Z Resolving github.com (github.com)... failed: No address associated with hostname.
2024-11-21T17:30:10.5100558Z wget: unable to resolve host address 'github.com'

but the previous wget calls worked, maybe a hickup and re-run?

Wondering why the required Windows Build and Test + SonarCloud analysis jobs failed since the PR does not touch anything related and the PR doesn't look to be in any relation with the error

ERROR: Error during SonarScanner execution
ERROR: Project not found.

Is there anything I can do so we proceed?

mgallien commented 18 hours ago

@cmuck sonarcloud cannot run correctly for external clone of the main repository due to the need to access a secret that cannot be accessed from your clone the windows CI was failing and I fixed it yesterday thanks for the help and your contribution very much appreciated