Draft: Feature/tray tabs

nextcloud / desktop

💻 Desktop sync client for Nextcloud

https://nextcloud.com/install/#install-clients

GNU General Public License v2.0

3.06k stars 804 forks source link

Draft: Feature/tray tabs #7507

Closed claucambra closed 3 days ago

claucambra commented 4 days ago

[!Important] Depends on #7498

It's very unclear in the current tray window UI how the search bar relates to the activities view. It, in fact, has no real relation, as it invokes unified search.

To clarify the two very separate functionalities of these window components, a tabbed UI makes sense (and makes sense for future additions)

Current state:

nextcloud-desktop-bot commented 4 days ago

AppImage file: nextcloud-PR-7507-20e2bd79e0f8aa7f921dbf9f3c311965ac6ca5db-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarcloud[bot] commented 4 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Rello commented 4 days ago

Thank you @claucambra what is this extra line on top? can we get rid of this?

and, can the current selected tab be e.g. completely white - same color as the area below? this would indicate better, which one is connected.

Hyeyoung346 commented 4 days ago

I also agree with @jancborchardt that the search box shouldn't be a separate tab. Somehow the “Talk” app and the search icon look similar, making it look confusing. I think further design improvements need further investigation. I'm wondering if we change the background color to white now? I cannot catch up with where we have changed so far. @claucambra