search

nextcloud / docker

⛴ Docker image of Nextcloud
https://hub.docker.com/_/nextcloud/
GNU Affero General Public License v3.0
5.95k stars 1.82k forks source link

Add NGINX unit image / or use add to nextcloud-fpm #1063

Open strannick-ru opened 4 years ago

strannick-ru commented 4 years ago

Hello.

How about use nginx unit in your nextcloud-fpm images? For debian its really simple — just add nginx unit repo, install it, add config and make little change into entrypoint.sh.

What is for? You get best from two apps — php-fpm for php and nginx for static files. It will be like nextcloud-apache image, but suitable for heavy loads.

links: https://hub.docker.com/r/nginx/unit/ https://unit.nginx.org/

dm3ch commented 2 years ago

@J0WI @tilosp Is there any chance that there would be added official docker image using nginx-unit? Not as a replacement of php-fpm, but as a new distribution option (like apache). If maintainers are ready to merge such contribution, I'm ready to update existing ananace PR or recreate it from scratch.

P.S. Sorry for mentioning

J0WI commented 1 year ago

Unfortunately no. There is neither support or documentation from Nextcloud nor is this a common setup in the official Docker library. There is also no official unit image and we cannot use third party base image as proposed in #1610.

So far, there was not much demand for this, but feel free to contribute any documentation or examples.

tippexs commented 11 months ago

Hello @J0WI sorry for picking up this "old" issue again. But a lot has changed since 2022 and we are now an official Docker Image and NGINX Unit is a true alternative to PHP-FPM.

I have just created a new configuration for NC 27.1.2. I would love to contribute this if we can find a way adding Unit to the NC update script in some sort. If this is not possible is there a way to contribute to your docs? To me a documentation about how to use NGINX Unit for NC is better placed somewhere on your end as on ours. I am happy to share everything we have to make this happen! Just let me know.

Cheers Timo from NGINX :)

gaigelama commented 11 months ago

Hello @J0WI sorry for picking up this "old" issue again. But a lot has changed since 2022 and we are now an official Docker Image and NGINX Unit is a true alternative to PHP-FPM.

I have just created a new configuration for NC 27.1.2. I would love to contribute this if we can find a way adding Unit to the NC update script in some sort. If this is not possible is there a way to contribute to your docs? To me a documentation about how to use NGINX Unit for NC is better placed somewhere on your end as on ours. I am happy to share everything we have to make this happen! Just let me know.

Cheers Timo from NGINX :)

I was just checking this thread out a couple days ago and was going to comment that there was now an official NGINX Unit image but didn't have time. I circled back today to see your reply and it couldn't get any better than that lol.

If you get something pushed to Docker Hub or another public registry I can test this out on Nextcloud on k8s and provide feedback.

Thanks for taking an interest and getting something started @tippexs .

tippexs commented 11 months ago

Thanks @gaigelama sounds great! I will push my updates to a git repository and push the image to docker hub. Will share it later today with you.

gaigelama commented 11 months ago

I'm not associated with Nextcloud or this repo so I unfortunately can't speak on their behalf. Taking a look at the open/merged PRs and the CoC though, PRs seem to be welcome. Hopefully a maintainer can better assist you soon.

J0WI commented 10 months ago

If this is not possible is there a way to contribute to your docs? To me a documentation about how to use NGINX Unit for NC is better placed somewhere on your end as on ours.

The canonical documentation lives at https://github.com/nextcloud/documentation. That's also the reference for the nginx examples in this repo. Does unit require any change in the Nextcloud image or is this just an alternative for the nginx example?

tippexs commented 10 months ago

Hi @J0WI sorry for my late response!

Unit does not require any changes in the Nextcloud image. It is a simpler way to deploy PHP applications with NGINX without having the need of two seperate processes (NGINX and PHP-FPM).

I have just worked on an issue in our repositories. https://github.com/nginx/unit/issues/959 Let me know if you need a template Dockerfile or configuration.

ananace commented 9 months ago

I pushed some updates to #1610 - it now results in what looks to be a fully functional install, including support for pretty URLs.

I've in fact moved my personal nextcloud instance onto it to further dogfood the image.