search

nextcloud / end_to_end_encryption_rfc

🔒 Specification for end-to-end encryption used by Nextcloud sync & mobile apps
Other
31 stars 15 forks source link

Signature fix #22

Closed woefe closed 5 years ago

woefe commented 5 years ago
jospoortvliet commented 5 years ago

So I reviewed the text - most of it I can judge and it is fine. There's some commits I find hard to judge as I just lack the tech know-how, these need @rullzer and @tobiasKaminsky https://github.com/nextcloud/end_to_end_encryption_rfc/pull/22/commits/3570fce932701f752133ec0a8f341529ea12aafb https://github.com/nextcloud/end_to_end_encryption_rfc/pull/22/commits/2832011c0c2eba771ee97a33ed61bdf35b56e862

As I said, the rest is good but now we have conflicts... We should merge this asap after these are resolved so we don't spend forever with this big PR.

I would even suggest it might make sense to separate this in 2-3 PR's, pls don't make such big ones @woefe - just too big to review and merge! The typo's separate is much easier, for example, and I see there's overlap with one I did and roeland of course.

jospoortvliet commented 5 years ago

Maybe the best thing is to separately do the commits in a few separate PR's...

woefe commented 5 years ago

Sorry for the big PR. I just kept adding stuff during the Hackweek without thinking about consequences. I could not find a proper way to split this into multiple PRs, and how exactly would I do that? I tried cherry picking commits to new branches, but since it is only one file and most commits build on top of each other I could not find a good way to break it down into smaller PRs.

tobiasKaminsky commented 5 years ago

@woefe do not worry about this. @jospoortvliet we plan to have a small E2E hackweek and then we will discuss this further, with Björn, Marino, Roleand, Wolfgang and me. After that we can just merge it.

tobiasKaminsky commented 5 years ago

@woefe do not worry about this. @jospoortvliet we plan to have a small E2E hackweek and then we will discuss this further, with Björn, Marino, Roleand, Wolfgang and me. After that we can just merge it.

tobiasKaminsky commented 5 years ago

@woefe do not worry about this. @jospoortvliet we plan to have a small E2E hackweek and then we will discuss this further, with Björn, Marino, Roleand, Wolfgang and me. After that we can just merge it.

tobiasKaminsky commented 5 years ago

This is obsolete/included with v2, or?

woefe commented 5 years ago

Yes this is obsolete with v2. I double checked the diff with v2 and everything that is still relevant from this PR also seems to be in v2.