search

nextcloud / event_update_notification

GNU Affero General Public License v3.0
13 stars 3 forks source link

Diff of event updates #52

Open nickvergessen opened 1 year ago

nickvergessen commented 1 year ago

With https://github.com/nextcloud/server/pull/35743#issuecomment-1370556968 it might be possible to improve the update notification to outline what changed (name, time, ...?)

phil-lipp commented 1 year ago

Yes, that would be great! The notifications right now are pretty bare bones and sometimes plain useless as I cant see what another person changed. Having 5 notifications of "Person A changed event X" and trying to figure out what each individual changed is not feasible most of the time.

nickvergessen commented 1 year ago

Having 5 notifications of "Person A changed event X" and trying to figure out what each individual changed is not feasible most of the time.

Well depends of course. In my home usecase the mostlikely thing to change is the time and the starting time is also visible in the notifications, so for me the most important info is there.

But yeah I will look into adding at least the list of changed properties

nickvergessen commented 1 year ago

Hmm actually we don't receive the "before" data in the CalendarObjectUpdatedEvent event so we can also not diff it :(

phil-lipp commented 1 year ago

Hmm actually we don't receive the "before" data in the CalendarObjectUpdatedEvent event so we can also not diff it :(

Well then can't that change? Is it not possible for the server to provide that info?

nickvergessen commented 1 year ago

It would be possible I guess, but required some work on multiple levels and I'm not familiar with that code base