nextcloud / external

🌐 Embed external sites in your Nextcloud
https://apps.nextcloud.com/apps/external
GNU Affero General Public License v3.0
110 stars 31 forks source link

Provide file is not an image - External 3.8.1 Netcloud server 21.0.1.1 #253

Open stratege1401 opened 3 years ago

stratege1401 commented 3 years ago

Provide file is not an image - External 3.8.1 Netcloud server 21.0.1.1

Steps to reproduce

trying to upload a new Icon for external site.

Expected behaviour

png/svg/jpg should be uploading

Actual behaviour

Whater format i use ( jpg, png, svg ) end's up with error: Upload new icon: myfiles.png Provided file is not an image. xxx.png file size is 5k

Server configuration detail

Operating system: Linux 5.10.0-6-amd64 #1 SMP Debian 5.10.28-1 (2021-04-09) x86_64

Webserver: Apache (apache2handler)

Database: mysql 10.5.9

PHP version:

7.4.15 Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, session, standard, sodium, apache2handler, mysqlnd, PDO, xml, apcu, bcmath, bz2, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, igbinary, imagick, imap, intl, json, exif, mysqli, pdo_mysql, apc, posix, readline, redis, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, Phar, Zend OPcache

Nextcloud version: 21.0.1 - 21.0.1.1

Updated from an older Nextcloud/ownCloud or fresh install: NO - Fresh install

Where did you install Nextcloud from: Used official nextcloud-setting.php

Signing status Array ( )
List of activated apps ``` Enabled: - accessibility: 1.7.0 - activity: 2.14.3 - announcementcenter: 5.0.0 - apporder: 0.12.0 - auto_groups: 1.3.1 - breezedark: 21.0.7 - bruteforcesettings: 2.1.0 - camerarawpreviews: 0.7.11 - cloud_federation_api: 1.4.0 - comments: 1.11.0 - contactsinteraction: 1.2.0 - data_request: 1.8.0 - dav: 1.17.1 - defaultgroup: 0.3.0 - external: 3.8.1 - federatedfilesharing: 1.11.0 - federation: 1.11.0 - files: 1.16.0 - files_downloadactivity: 1.10.0 - files_pdfviewer: 2.1.0 - files_rightclick: 1.0.0 - files_sharing: 1.13.1 - files_snapshots: 1.0.1 - files_trashbin: 1.11.0 - files_versions: 1.14.0 - files_videoplayer: 1.10.0 - firstrunwizard: 2.10.0 - group_default_quota: 0.1.1 - groupquota: 0.1.5 - impersonate: 1.8.0 - issuetemplate: 0.7.0 - logreader: 2.6.0 - lookup_server_connector: 1.9.0 - nextcloud_announcements: 1.10.0 - notifications: 2.9.0 - oauth2: 1.9.0 - occweb: 0.0.7 - password_policy: 1.11.0 - photos: 1.3.0 - previewgenerator: 3.1.1 - privacy: 1.5.0 - provisioning_api: 1.11.0 - quota_warning: 1.10.0 - recommendations: 1.0.0 - registration: 1.2.1 - serverinfo: 1.11.0 - settings: 1.3.0 - sharebymail: 1.11.0 - support: 1.4.0 - survey_client: 1.9.0 - systemtags: 1.11.0 - terms_of_service: 1.7.0 - text: 3.2.0 - theming: 1.12.0 - twofactor_backupcodes: 1.10.0 - twofactor_email: 2.0.0 - twofactor_nextcloud_notification: 3.1.2 - twofactor_totp: 6.0.0 - twofactor_u2f: 6.1.0 - twofactor_webauthn: 0.2.9 - unsplash: 1.2.2 - updatenotification: 1.11.0 - user_status: 1.1.1 - viewer: 1.5.0 - weather_status: 1.1.0 - workflowengine: 2.3.0 Disabled: - admin_audit - dashboard - encryption - files_external - user_ldap ```
Configuration (config/config.php) ``` { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "mytrusteddomainremovefor.privacy.reason", "192.168.1.71" ], "memcache.local": "\\OC\\Memcache\\APCu", "datadirectory": "***REMOVED SENSITIVE VALUE***", "enable_previews": true, "preview_max_x": 4096, "preview_max_y": 4096, "preview_max_filesize_image": 50, "enabledPreviewProviders": [ "OC\\Preview\\PNG", "OC\\Preview\\JPEG", "OC\\Preview\\GIF", "OC\\Preview\\HEIC", "OC\\Preview\\BMP", "OC\\Preview\\XBitmap", "OC\\Preview\\MP3", "OC\\Preview\\TXT", "OC\\Preview\\MarkDown", "OC\\Preview\\OpenDocument", "OC\\Preview\\Krita" ], "default_language": "fr", "default_phone_region": "FR", "knowledgebaseenabled": true, "dbtype": "mysql", "version": "21.0.1.1", "overwrite.cli.url": "https:\/\/n2.rkn.ovh", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "mail_smtpmode": "smtp", "mail_smtpauthtype": "LOGIN", "mail_smtpsecure": "ssl", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpauth": 1, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "465", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "cache_chunk_gc_ttl": 86400, "filelocking.ttl": 3600, "auth.bruteforce.protection.enabled": false, "loglevel": 1, "updater.release.channel": "stable", "maintenance": false, "updater.secret": "***REMOVED SENSITIVE VALUE***", "app_install_overwrite": [ "occweb", "defaultgroup", "issuetemplate" ], "twofactor_enforced": "true", "twofactor_enforced_groups": [ "admin" ], "twofactor_enforced_excluded_groups": [] } ```

Are you using external storage, if yes which one: no

Are you using encryption:

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36

Operating system: irrelevant

Logs

Web server error log ``` NONE ```
Nextcloud log ``` {"reqId":"mSheFuZ6q1fTjjZ1hPhs","level":3,"time":"2021-05-10T16:23:04+00:00","remoteAddr":"192.168.1.254","user":"xxxxxxx","app":"PHP","method":"POST","url":"/index.php/apps/external/icons","message":{"Exception":"Error","Message":"getimagesize(): Filename cannot be empty at /var/www/html/apps/external/lib/Controller/IconController.php#91","Code":0,"Trace":[{"function":"onError","class":"OC\\Log\\ErrorHandler","type":"::"},{"file":"/var/www/html/apps/external/lib/Controller/IconController.php","line":91,"function":"getimagesize"},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":218,"function":"uploadIcon","class":"OCA\\External\\Controller\\IconController","type":"->"},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":127,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/var/www/html/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/var/www/html/lib/base.php","line":993,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/var/www/html/index.php","line":37,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/html/lib/private/Log/ErrorHandler.php","Line":92,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36","version":"21.0.1.1"} ```
Browser log irrelevant
nickvergessen commented 3 years ago

Can you provide the file?

stratege1401 commented 3 years ago

ipbd

test

test.zip

https://n2.rkn.ovh/index.php/s/SBKyAkcSLG82CMR

test zip is a svg, seem github does not support this file extension for uploading.

Failing with all of them. Failing with any others. And this is a fresh install test server, with allow uploading and is running as my personal test rig ( meaning chown and chmod or vhost allow uploading, of course )

stratege1401 commented 3 years ago

Issue still alive after updating nextcloud to 21.0.2

nickvergessen commented 3 years ago

Not sure what's wrong for you. The file works fine here.

FoxXxHater commented 3 years ago

I have the same Error... I have the Nextcloud Version "20.0.12 - 20.0.12.1"

P.S. its an new Installation

FoxXxHater commented 3 years ago

https://user-images.githubusercontent.com/54017453/132108291-9402939b-009e-4586-b4c4-c50437efac95.mp4

In this Video we can see that i select the "google-logo.png" an then the "error"

github-actions[bot] commented 1 year ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, we would appreciate your feedback on your experience with our community management team.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

provokateurin commented 1 year ago

@stratege1401 can you test this on the latest versions of the server and this app? I'm not able to reproduce this either with the image you provided and Firefox reports the correct mime type. I wonder if your instance is missing imagick svg support and if that could be the problem in this case :thinking: