Make groupfolders more visible

[tobiasKaminsky]

• [x] Android: https://github.com/nextcloud/android/pull/11526
• [x] Android library: https://github.com/nextcloud/android-library/pull/1109
• [x] Desktop: https://github.com/nextcloud/desktop/pull/5636
• [x] iOS:
• [x] Server:
  • [x] https://github.com/nextcloud/groupfolders/pull/2327
  • [x] https://github.com/nextcloud/groupfolders/pull/2328

Goal is to give our groupfolder system more visibility.

• [x] Retrieve all folders that are groupfolders, API is pending
• [x] in capabilities: groupfolder for user: yes/no
• [ ] icon: shared folder icon, might be replaced by another one

Android @tobiasKaminsky:

• [x] in navigation, beneath "Shared": new entry "Groupfolders"
• show list of available groupfolders, on click navigate to it

Desktop @mgallien:

• [ ] in tray menu: folder icon will become dropdown
  • first entry: "main folder"
  • then list all groupfolders -> click on it opens folder (if synced, else explain it)
  • if only one entry -> do not show dropdown

iOS @marinofaggiana:

• [ ] in "more" -> "Groupfolders"
• show list of available groupfolders, on click navigate to it

[mgallien]

@tobiasKaminsky do you have a mock up of what it would look like ? we currently handle them like external storage so if they are selected the activity from them would already appear in the activity list maybe I misunderstand something here

[tobiasKaminsky]

It is about this view and about "folder" icon (the one with green sync icon). On Desktop it is basically to have a shortcut to those groupfolders.

[marinofaggiana]

Is in WIP the capabilities: groupfolder for user: yes/no ?? because in NC26 is not present (yet)

[tobiasKaminsky]

Will be at some point in groupfolders app, and then we can use it. Might be backported to NC26, but clients shall only rely on capability.

[marinofaggiana]

I would propose the addition in share (like server)

[tobiasKaminsky]

Let us first do the minimum, and if time allows, we can add this to share handling.

[tobiasKaminsky]

},
                "groupfolders": {
                    "hasGroupFolders": true
                },

We have on e2e.kaminsky.me, user "tag" this now active. So we can do:

• if property is not available (<NC27) or "false" -> do not show entry / dropdown
• if property is "true" -> use it

[tobiasKaminsky]

@marinofaggiana @mgallien ^

[marinofaggiana]

@tobiasKaminsky: in my NC26 for NOT admin:

GET https://nextcloud.homelinux.org/index.php/apps/groupfolders/folders error 500 < {"message":"Logged in user must be an admin, a sub admin or gotten special right to access this setting"} >

as admin group, no problem.

[tobiasKaminsky]

This is not yet in NC26, thus please use e2e.kaminsky.me server, where all needed PRs are applied.

[tobiasKaminsky]

@marinofaggiana @mgallien in request to list groupfolders please add applicable=1, as this then shows also for admin user correct info: /index.php/apps/groupfolders/folders?applicable=1

[tobiasKaminsky]

@jancborchardt when we first spoke about this feature, you mentioned that icon might change. So, will we have a new icon? :)

[tobiasKaminsky]

Capability:

    "groupfolders": {
                    "hasGroupFolders": true
                },

List of groupfolders: curl --request GET \ --url 'https://e2e.kaminsky.me/index.php/apps/groupfolders/folders?format=json&applicable=1' \ --header 'OCS-APIRequest: true'

output:

{
    "ocs": {
        "meta": {
            "status": "ok",
            "statuscode": 100,
            "message": "OK",
            "totalitems": "",
            "itemsperpage": ""
        },
        "data": {
            "1": {
                "id": 1,
                "mount_point": "\/groupfolder",
                "groups": {
                    "users": 31
                },
                "quota": -3,
                "size": 1896240,
                "acl": false,
                "manage": []
            },
            "2": {
                "id": 2,
                "mount_point": "\/subfolder\/group",
                "groups": {
                    "users": 31
                },
                "quota": -3,
                "size": 2604768,
                "acl": false,
                "manage": []
            }
        }
    }
}

[tobiasKaminsky]

All done.