Closed tobiasKaminsky closed 1 year ago
@marino you can use our e2e.kaminsky.me test server with PROPFIND:
PROPFIND with
@tobiasKaminsky but for added / select a tag ?
Right now it is only for showing tags. Nothing more is needed :)
ok
iOS:
Android:
@jancborchardt I am unsure if two lines will fit…It will then look on iOS also cluttered, same as on Android…
iOS:
Android:
@jancborchardt I am unsure if two lines will fit…It will then look on iOS also cluttered, same as on Android…
Note we will have the same issue on activities on desktop, particularly for those that are already showing changes to several files
Yes ... isn't good ...
Yeah, we should definitely not have multiple sublines.
How about if there are tags on a file, we just replace the current subline info about file size and date with the tags? Everything is still visible in the details.
We just need to make sure the tag text is on the same baseline as the current date and time text so it looks nice. And the border of the tags can also be a bit lighter to look less busy.
@jancborchardt
How about if there are tags on a file, we just replace the current subline info about file size and date with the tags? Everything is still visible in the details.
Nice idea. Shall we then still only have one tag? and then "+x" as second? Or shall we have 2 tags and then "+x"? (I have no idea how many tags usually are used…)
We can definitely show more than one tag, however much space there is of course.
@tobiasKaminsky for Android the border color of the tag can be a bit lighter, and the tags are a bit too low compared to the size/date text.
@marinofaggiana for iOS it looks nice in the file list, good job! Can you there also show more than just 1 tag? 2 at least we could show, of course depending on length of text. :)
@marinofaggiana @claucambra we now have official API: PROPFIND with < system-tags xmlns="http://nextcloud.org/ns"/ > results in:
<nc:system-tags>
<nc:system-tag oc:can-assign="true" oc:id="3" oc:user-assignable="true" oc:user-visible="true">important</nc:system-tag>
</nc:system-tags>
For us, right now, only name is important.
You can test it/use it on: e2e.kaminsky.me user: tag
Server: Webdav property is: "tags". Output:
Android/iOS @tobiasKaminsky @marinofaggiana:
Desktop @claucambra :
in activity list (ping @nickvergessen if API change in needed), in subline, same as Android/iOSMockup:![image](https://user-images.githubusercontent.com/5836855/230104942-256735fa-39ce-4b68-9b2e-5268f097abcc.png)