nextcloud / files-clients

1 stars 0 forks source link

Show tags in file/folder listing #39

Closed tobiasKaminsky closed 1 year ago

tobiasKaminsky commented 1 year ago

Server: Webdav property is: "tags". Output:

<nc:sharees/>
<nc:tags>
  <oc:tag>test 0</oc:tag>
</nc:tags>

Android/iOS @tobiasKaminsky @marinofaggiana:

Desktop @claucambra : in activity list (ping @nickvergessen if API change in needed), in subline, same as Android/iOS

Mockup: image

tobiasKaminsky commented 1 year ago

@marino you can use our e2e.kaminsky.me test server with PROPFIND:

PROPFIND with results in:

test 0 test 1 test 2 test 3 (nc vs oc might change, as this is strange right now)
marinofaggiana commented 1 year ago
Screenshot 2023-04-10 alle 15 31 34
marinofaggiana commented 1 year ago

@tobiasKaminsky but for added / select a tag ?

tobiasKaminsky commented 1 year ago

Right now it is only for showing tags. Nothing more is needed :)

marinofaggiana commented 1 year ago

ok

tobiasKaminsky commented 1 year ago

iOS: image

Android: image

@jancborchardt I am unsure if two lines will fit…It will then look on iOS also cluttered, same as on Android…

claucambra commented 1 year ago

Opened https://github.com/nextcloud/desktop/pull/5596

claucambra commented 1 year ago

iOS: image

Android: image

@jancborchardt I am unsure if two lines will fit…It will then look on iOS also cluttered, same as on Android…

Note we will have the same issue on activities on desktop, particularly for those that are already showing changes to several files

marinofaggiana commented 1 year ago

Yes ... isn't good ...

jancborchardt commented 1 year ago

Yeah, we should definitely not have multiple sublines.

How about if there are tags on a file, we just replace the current subline info about file size and date with the tags? Everything is still visible in the details.

We just need to make sure the tag text is on the same baseline as the current date and time text so it looks nice. And the border of the tags can also be a bit lighter to look less busy.

marinofaggiana commented 1 year ago

@jancborchardt

Screenshot 2023-04-12 alle 15 44 39

Simulator Screenshot - iPhone 14 - 2023-04-12 at 15 44 51

tobiasKaminsky commented 1 year ago

How about if there are tags on a file, we just replace the current subline info about file size and date with the tags? Everything is still visible in the details.

Nice idea. Shall we then still only have one tag? and then "+x" as second? Or shall we have 2 tags and then "+x"? (I have no idea how many tags usually are used…)

tobiasKaminsky commented 1 year ago

2023-04-12-160006

jancborchardt commented 1 year ago

We can definitely show more than one tag, however much space there is of course.

@tobiasKaminsky for Android the border color of the tag can be a bit lighter, and the tags are a bit too low compared to the size/date text.

@marinofaggiana for iOS it looks nice in the file list, good job! Can you there also show more than just 1 tag? 2 at least we could show, of course depending on length of text. :)

tobiasKaminsky commented 1 year ago

@marinofaggiana @claucambra we now have official API: PROPFIND with < system-tags xmlns="http://nextcloud.org/ns"/ > results in:

<nc:system-tags>
                    <nc:system-tag oc:can-assign="true" oc:id="3" oc:user-assignable="true" oc:user-visible="true">important</nc:system-tag>
                </nc:system-tags>

For us, right now, only name is important.

You can test it/use it on: e2e.kaminsky.me user: tag