nextcloud / files_accesscontrol

🚫 App to manage access control for files
https://apps.nextcloud.com/apps/files_accesscontrol
50 stars 20 forks source link

Image Preview in Memories available for blocked file #543

Closed ManfredWisniewski closed 3 months ago

ManfredWisniewski commented 3 months ago

Steps to reproduce

  1. block access to a file
  2. open the memories app (timeline, map etc.)
  3. image previews are shown, if you click on one the image is displayed but then gets removed this affects the preview on the map as well as on the right hand timeline

Expected behaviour

No preview should be available

Actual behaviour

previews of blocked files are displayed

In this example all the files from Sat, May 25 are in a directory that is blocked for the user. Image no1: preview available image Image no2: image loading with preview in the background image Image no3: image gets removed when loading finishes image

nickvergessen commented 3 months ago

Are you sure they are not just cached in your browser? This app works on Storage layer level. We don't actually care how or which app is loading an image. If that is still a real issue, the memory app would be doing some real deep hacking/working around.

ManfredWisniewski commented 3 months ago

Are you sure they are not just cached in your browser?

You are correct! I tested it with a clean cache for the user that has no access and he can only see the default thumbnail icon - no preview. Not a real issue. Thanks!