nextcloud / files_downloadactivity

📥⚡ Creates activities for downloads of shared files
https://apps.nextcloud.com/apps/files_downloadactivity
GNU Affero General Public License v3.0
40 stars 21 forks source link

When will Nextcloud 27 and 28, 29 and 30 support be added? #165

Closed arno4000 closed 3 months ago

arno4000 commented 9 months ago

Steps to reproduce

  1. Install the app on Nextcloud 27
  2. Get the message Error: This app cannot be enabled because it makes the server unstable when enabling the app. When the app is enabled via occ app:enable files_downloadactivity, there is no error message.

Expected behaviour

The app should work on Nextcloud versions, which are not EOL in two months.

Actual behaviour

The app does not work in Nextcloud Versions which are newer than 26

Sblop commented 9 months ago

+1

BloodyIron commented 9 months ago

Can we please get this just mainlined into nextCloud already? This really should be core functionality by default. Tracking activity across large nextCloud instances requires things like this.

arno4000 commented 9 months ago

FYI: It works on NC 27 if you increase the max version in the info.xml of the app. But this is a hacky workaround which can potentially break at any time. It would be nice if the app would be updated before a new version of nextcloud is released.

immanuelfodor commented 8 months ago

There was probably a change in NC as well as my logs are splattered everywhere with "message":"Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()"

WechuTM commented 8 months ago

https://github.com/christian-baumann/files_downloadactivity/commit/a5f5f7a4fd101258da8563111c349ed3679162ce This file modification enables the application to be used on NC 28.0.3 RC1 👍

nooblag commented 8 months ago

There was probably a change in NC as well as my logs are splattered everywhere with "message":"Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()"

Also reporting this, thousands of lines per day.

```json{ "reqId": "lbOJJ5AsMSseYz5GZRDP", "level": 4, "time": "2024-02-29T23:13:52+11:00", "remoteAddr": "xxx.xxx.xxx.xxx", "user": "x", "app": "no app in context", "method": "GET", "url": "/apps/logreader/api/poll?lastReqId=xxx", "message": "Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()", "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36", "version": "28.0.3.2", "exception": { "Exception": "Error", "Message": "Call to undefined method OC\\Server::getEventDispatcher()", "Code": 0, "Trace": [ { "file": "/var/www/nextcloud/lib/private/AppFramework/Bootstrap/Coordinator.php", "line": 200, "function": "boot", "class": "OCA\\FilesDownloadActivity\\AppInfo\\Application", "type": "->" }, { "file": "/var/www/nextcloud/lib/private/App/AppManager.php", "line": 434, "function": "bootApp", "class": "OC\\AppFramework\\Bootstrap\\Coordinator", "type": "->" }, { "file": "/var/www/nextcloud/lib/private/App/AppManager.php", "line": 213, "function": "loadApp", "class": "OC\\App\\AppManager", "type": "->" }, { "file": "/var/www/nextcloud/lib/private/legacy/OC_App.php", "line": 125, "function": "loadApps", "class": "OC\\App\\AppManager", "type": "->" }, { "file": "/var/www/nextcloud/lib/base.php", "line": 1049, "function": "loadApps", "class": "OC_App", "type": "::" }, { "file": "/var/www/nextcloud/index.php", "line": 39, "function": "handleRequest", "class": "OC", "type": "::" } ], "File": "/var/www/nextcloud/apps/files_downloadactivity/lib/AppInfo/Application.php", "Line": 49, "message": "Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()", "exception": [], "CustomMessage": "Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()" }, "id": "xxx" } ```
WechuTM commented 8 months ago

There was probably a change in NC as well as my logs are splattered everywhere with "message":"Could not boot files_downloadactivity: Call to undefined method OC\\Server::getEventDispatcher()"

Also reporting this, thousands of lines per day.

Make the modifications described in the post https://github.com/christian-baumann/files_downloadactivity/commit/a5f5f7a4fd101258da8563111c349ed3679162ce should remove the error

nooblag commented 8 months ago

Thanks for that. I'd prefer an update released though, not too comfortable modifying files. Also, it'd be great if this app was made redundant anyways by mainlining like @BloodyIron suggested :) Would love that

BloodyIron commented 8 months ago

Yeah I literally need this functionality at this time (this week and going forward) for determining if my clients are downloading things I'm sharing with them. Right now I'm not sure if I can tell at all. And with this falling to the wayside for development, it really should be mainlined so it can get love when it needs it. Are there roadblocks or something?

sephentos commented 6 months ago

Title should be updated to include NC 29.0.0 :P

skjnldsv commented 3 months ago

For everyone, the app needs to be updated, sure, but you can force enable it. It works just fine :see_no_evil:

skjnldsv commented 3 months ago

Only the Call to undefined method OC\\Server::getEventDispatcher() :eyes:

skjnldsv commented 3 months ago

Fixed in upcoming release

BloodyIron commented 3 months ago

Yay! But will this ever be mainlined?