nextcloud / files_downloadactivity

📥⚡ Creates activities for downloads of shared files
https://apps.nextcloud.com/apps/files_downloadactivity
GNU Affero General Public License v3.0
40 stars 21 forks source link

Multiple activity logs through audio or video player #47

Open simonspa opened 4 years ago

simonspa commented 4 years ago

Whenever I share media such as audio files and the recipient not only downloads them but listens to them using the embedded player, jumping back and forth in the timeline, an activity is generated.

Is there a way of suppressing this in the download activity app?

Steps to reproduce

  1. Share audio file via public link
  2. Recipient listens to the audio and jumps back and forth in the timeline
  3. Recipient finally downloads file

Expected behaviour

The actions are shown as one (or maybe two) activities in the stream: listening and downloading account for one each.

Actual behaviour

Each time the recipient jumps in the timeline of the audio file, the action is counted as a new download, leading to 30+ activity entries if a user listens a while.

Server configuration detail

Operating system: Linux 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3+deb9u1 (2019-09-20) x86_64

Webserver: nginx/1.10.3 (fpm-fcgi)

Database: mysql 10.1.41

PHP version:

7.2.22-1+0~20190902.26+debian9~1.gbpd64eb7 Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, sodium, session, standard, cgi-fcgi, mysqlnd, PDO, xml, apcu, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, igbinary, imagick, intl, json, exif, mysqli, pdo_mysql, apc, posix, readline, redis, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, Phar, Zend OPcache

Nextcloud version: 16.0.4 - 16.0.4.1

Updated from an older Nextcloud/ownCloud or fresh install: Update from ownCloud 5.0

Where did you install Nextcloud from: unknown

Signing status Array ( )
List of activated apps ``` Enabled: - accessibility: 1.2.0 - activity: 2.9.1 - admin_audit: 1.6.0 - apporder: 0.7.1 - bookmarks: 2.1.1 - bruteforcesettings: 1.4.0 - calendar: 1.7.1 - cloud_federation_api: 0.2.0 - comments: 1.6.0 - contacts: 3.1.4 - dav: 1.9.2 - drawio: 0.9.4 - event_update_notification: 0.3.4 - federatedfilesharing: 1.6.0 - federation: 1.6.0 - files: 1.11.0 - files_downloadactivity: 1.5.0 - files_markdown: 2.1.0 - files_pdfviewer: 1.5.0 - files_rightclick: 0.15.1 - files_sharing: 1.8.0 - files_texteditor: 2.8.0 - files_trashbin: 1.6.0 - files_versions: 1.9.0 - files_videoplayer: 1.5.0 - firstrunwizard: 2.5.0 - gallery: 18.3.0 - impersonate: 1.3.0 - issuetemplate: 0.5.0 - logreader: 2.1.0 - lookup_server_connector: 1.4.0 - metadata: 0.9.0 - notes: 3.0.3 - notifications: 2.4.1 - oauth2: 1.4.2 - password_policy: 1.6.0 - passwords: 2019.9.1 - previewgenerator: 2.1.0 - privacy: 1.0.0 - provisioning_api: 1.6.0 - quota_warning: 1.5.0 - serverinfo: 1.6.0 - sharebymail: 1.6.0 - tasks: 0.11.3 - telephoneprovider: 1.0.2 - text: 1.0.2 - theming: 1.7.0 - twofactor_admin: 0.4.1 - twofactor_backupcodes: 1.5.0 - twofactor_u2f: 3.0.1 - updatenotification: 1.6.0 - viewer: 1.1.0 - workflowengine: 1.6.0 Disabled: - deck - encryption - files_external - groupfolders - mail - nextcloud_announcements - recommendations - support - survey_client - systemtags - user_ldap ```
Configuration (config/config.php) ``` { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "xxxxxxxxx", ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "16.0.4.1", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "logtimezone": "Europe\/Berlin", "installed": true, "maintenance": false, "memcache.local": "\\OC\\Memcache\\APCu", "filelocking.enabled": "true", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 0, "password": "***REMOVED SENSITIVE VALUE***", "timeout": 0 }, "log_rotate_size": "104857600", "theme": "", "loglevel": 2, "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpauthtype": "LOGIN", "mail_smtpauth": 1, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "465", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "mail_smtpsecure": "ssl", "htaccess.RewriteBase": "\/", "updater.release.channel": "stable", "data-fingerprint": "58897020af7835d5d5eebe9f70033c28", "preview_max_x": 2048, "preview_max_y": 2048, "activity_expire_days": 90, "knowledgebaseenabled": false, "simpleSignUpLink.shown": false, "mysql.utf8mb4": true } ```

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption:

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Client configuration

Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Operating system: Various/independent

Logs

Web server error log ``` Insert your web server log here ```
Nextcloud log ``` Insert your Nextcloud log here ```
Browser log Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ...
nickvergessen commented 4 years ago

Puh, I don't think so, but I will try to have a look when I got some free time again.

simonspa commented 4 years ago

I already thought it might not be easily done. I guess the alternative is to simply disable the audio player for link shares - but that doesn't seem to be possible at the moment?

emichael commented 3 years ago

Any progress on fixing this? We really need an option to disable these, or they should be completely disabled by default. I'm seeing constant spam when sharing video files.

davros123 commented 2 years ago

Still seeing this in 22.2.3. What's the solution?

Downloaded via public link 6 minutes ago Downloaded via public link 6 minutes ago Downloaded via public link 6 minutes ago Downloaded via public link 6 minutes ago Downloaded via public link 6 minutes ago

nickvergessen commented 2 years ago

Disable the app or download the file instead of streaming it.

A coding solution would be to create a new activity "X is streaming Y" when the request had seeking parameters and then grouping them. But I don't have any time for this at the moment

predsfan2 commented 10 months ago

Still happening 24.0.1

nickvergessen commented 10 months ago

Still happening 24.0.1

That version is very old and not even supported anymore. You should update to 26 at least to be on a supported version again: https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule