search

nextcloud / files_downloadlimit

Nextcloud link share download counter
https://apps.nextcloud.com/apps/files_downloadlimit
GNU Affero General Public License v3.0
10 stars 4 forks source link

Download Limit Applied Against User Choice #422

Open i2h3 opened 18 hours ago

i2h3 commented 18 hours ago

How to use GitHub

Steps to reproduce

  1. Have a file which is not shared yet.
  2. Create a sharing link.
  3. Customize the sharing link by adding a title but do not customize anything else.
  4. Apply changes.
  5. Reopen customization options.

Expected behaviour

The downloads of the share are not limited.

Alternatively, depending on the semantics of the administration setting for default share limit, show that a limit is applied automatically when the user does not explicitly choose differently.

Actual behaviour

The default value set in the administration settings is applied. Maybe I am misunderstanding the intention of the possibility to set the default downloads limit value. I did not expect it to be automatically forced onto my newly created share. And if that is the intended behavior of the feature, I would at least expect it to be visible in the initial share customization. A user would not notice the limited downloads for created shares without looking into the share customization options a second time.

Server configuration

Web server: Whatever is default in most recent Nextcloud All-in-One release 🤷🏻‍♀️

Database: PostgreSQL

PHP version: Whatever is default in most recent Nextcloud All-in-One release 🤷🏻‍♀️

Nextcloud version: 30.0.1.2

List of activated apps ``` Enabled: - activity: 3.0.0 - admin_audit: 1.20.0 - app_api: 4.0.0 - bruteforcesettings: 3.0.0 - calendar: 5.0.1 - circles: 30.0.0-dev - cloud_federation_api: 1.13.0 - comments: 1.20.1 - contacts: 6.1.0 - contactsinteraction: 1.11.0 - dashboard: 7.10.0 - dav: 1.31.1 - federatedfilesharing: 1.20.0 - federation: 1.20.0 - files: 2.2.0 - files_downloadlimit: 3.0.0 - files_pdfviewer: 3.0.0 - files_reminders: 1.3.0 - files_sharing: 1.22.0 - files_trashbin: 1.20.1 - files_versions: 1.23.0 - firstrunwizard: 3.0.0 - logreader: 3.0.0 - lookup_server_connector: 1.18.0 - nextcloud-aio: 0.6.0 - nextcloud_announcements: 2.0.0 - notes: 4.11.0 - notifications: 3.0.0 - notify_push: 0.7.0 - oauth2: 1.18.1 - password_policy: 2.0.0 - photos: 3.0.2 - privacy: 2.0.0 - provisioning_api: 1.20.0 - related_resources: 1.5.0 - serverinfo: 2.0.0 - settings: 1.13.0 - sharebymail: 1.20.0 - spreed: 20.0.2 - support: 2.0.0 - survey_client: 2.0.0 - systemtags: 1.20.0 - tasks: 0.16.1 - text: 4.1.0 - theming: 2.5.0 - twofactor_backupcodes: 1.19.0 - twofactor_totp: 12.0.0-dev - user_status: 1.10.0 - viewer: 3.0.0 - weather_status: 1.10.0 - webhook_listeners: 1.1.0-dev - workflowengine: 2.12.0 Disabled: - deck: 1.14.2 (installed 1.14.2) - encryption: 2.18.0 - files_external: 1.22.0 - recommendations: 3.0.0 (installed 3.0.0) - suspicious_login: 8.0.0 - twofactor_nextcloud_notification: 4.0.0 - user_ldap: 1.21.0 ```
Nextcloud configuration ``` { "system": { "upgrade.disable-web": true, "maintenance": false, "preview_max_x": 2048, "memcache.distributed": "\\OC\\Memcache\\Redis", "loglevel": 2, "trusted_domains": [ "localhost", "***REMOVED SENSITIVE VALUE***" ], "overwrite.cli.url": "https:\/\/***REMOVED SENSITIVE VALUE***\/", "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbname": "***REMOVED SENSITIVE VALUE***", "activity_expire_days": 30, "dbuser": "***REMOVED SENSITIVE VALUE***", "maintenance_window_start": 100, "DOMAIN": "***REMOVED SENSITIVE VALUE***", "dbtype": "pgsql", "jpeg_quality": 60, "passwordsalt": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "check_data_directory_permissions": false, "files_external_allow_create_new_local": false, "one-click-instance.user-limit": 100, "logfile": "\/var\/www\/html\/data\/nextcloud.log", "memcache.local": "\\OC\\Memcache\\APCu", "auth.bruteforce.protection.enabled": true, "memcache.locking": "\\OC\\Memcache\\Redis", "enable_previews": true, "preview_max_y": 2048, "installed": true, "apps_paths": [ { "path": "\/var\/www\/html\/apps", "url": "\/apps", "writable": false }, { "path": "\/var\/www\/html\/custom_apps", "url": "\/custom_apps", "writable": true } ], "share_folder": "\/Shared", "upgrade.cli-upgrade-link": "https:\/\/github.com\/nextcloud\/all-in-one\/discussions\/2726", "dbhost": "***REMOVED SENSITIVE VALUE***", "updatedirectory": "\/nc-updater", "dbport": "", "log.condition": { "apps": [ "admin_audit" ] }, "mail_smtpmode": "smtp", "htaccess.RewriteBase": "\/", "instanceid": "***REMOVED SENSITIVE VALUE***", "one-click-instance": true, "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "trashbin_retention_obligation": "auto, 30", "secret": "***REMOVED SENSITIVE VALUE***", "preview_imaginary_url": "***REMOVED SENSITIVE VALUE***", "overwriteprotocol": "https", "log_rotate_size": 10485760, "version": "30.0.1.2", "dbtableprefix": "oc_", "dbpersistent": false, "enabledPreviewProviders": { "7": "OC\\Preview\\Krita", "3": "OC\\Preview\\MP3", "4": "OC\\Preview\\TXT", "0": "OC\\Preview\\Imaginary", "5": "OC\\Preview\\OpenDocument", "1": "OC\\Preview\\Image", "6": "OC\\Preview\\Movie", "2": "OC\\Preview\\MarkDown" }, "app_install_overwrite": [ "nextcloud-aio" ], "davstorage.request_timeout": 3600, "one-click-instance.link": "https:\/\/nextcloud.com\/all-in-one\/", "overwritehost": "***REMOVED SENSITIVE VALUE***", "redis": { "password": "***REMOVED SENSITIVE VALUE***", "host": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "ratelimit.protection.enabled": true, "versions_retention_obligation": "auto, 30", "log_type": "file", "allow_local_remote_servers": true, "preview_imaginary_key": "***REMOVED SENSITIVE VALUE***", "simpleSignUpLink.shown": false } } ```

Browser

Browser name: Safari

Browser version: 18.1 (20619.2.8.11.10)

Operating system: macOS

i2h3 commented 18 hours ago

Screen Recording

https://github.com/user-attachments/assets/b38dc139-dfc7-40b0-bf85-9e82ad9e9cc8