Replace "open the location" behaviour with "open the file" one

nextcloud / files_fulltextsearch

🔍 Index the content of your files

GNU Affero General Public License v3.0

59 stars 30 forks source link

Replace "open the location" behaviour with "open the file" one #249

Open ostasevych opened 10 months ago

ostasevych commented 10 months ago

Typically, when searched for some document with the help of the universal search the document is opened, but not the location. However, in case of fulltext search the location is opened.

Would that be possible to make the approach universal?

My suggestion: in lib/Service/SearchService.php:

345 $this->urlGenerator->linkToRoute('files.view.index', ['dir' => $this->withoutEndSlash($dir), 'openfile' => $document->getId(), 'scrollto' => $filename])

XueSheng-GIT commented 8 months ago

I've updated to NC 28.0.2 and it seems that "scrollto" does not work anymore. Once you click on a file found via global search (fulltextsearch), just the directory itself is opened (but the file is not highlighted and scrollto does not work).

XueSheng-GIT commented 5 months ago

https://github.com/nextcloud/files_fulltextsearch/pull/253 is marked as merged but this patch is still missing for files_fulltextsearch 29.0.0. Any plan to release?