File locking to strict, README.md is almost always locked

schiessle commented 2 years ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] Nextcloud Server is running on 64bit capable CPU, PHP and OS.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

The README.md is almost always locked on my desktop.

I assume that this is the case because it always gets automatically opened and locked when someone navigates to the folder to show the content of the README at the top of the file listing. As this is most of the time read-only, this should not trigger the locking of the file unless someone really starts editing it. Otherwise it is impossible to edit the README files on the desktop.

I tried it once to unlock it manually on my file manager because I was quite sure that noone else edits it. But this result in a conflict file after my edit.

Steps to reproduce

Create a folder with a README.md
Sync it to the Desktop
Try to edit it, it should be almost always locked

Expected behavior

Being able to edit README.md files on the desktop if nobody else edit it (just open the document to show it in the rich workspaces ares shouldn't count as "editing")

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

[ ] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

c.nc.com

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

szaimen commented 2 years ago

cc @juliushaertl

juliushaertl commented 1 year ago

Just some unsorted thoughts - we could extend the lock interface so that:

App can register a class for their lock handling
This could implement a method to see if the lock should actually apply for a file operation
- For text we can check if there are still active users
- If the app handles conflicts or disappearing files (through delete) properly we can also allow those operations or
- Other option would be that text explicitly allows overruling the lock for README files

q-wertz commented 1 week ago

It also look like just opening the folder in the webinterface (without clicking on the Readme preview for editing) locks the file. And it keeps locked in this state. Tried to navigate to another folder or close the tab completely but still getting Locked Exception thrown: Sabre\DAV\Exception\Locked Exception thrown: Sabre\DAV\Exception\Locked errors in the log.

Also see: https://help.nextcloud.com/t/can-not-delete-readme-md/200374/2

nextcloud / files_lock