nextcloud / files_lock

GNU Affero General Public License v3.0
25 stars 8 forks source link

Does not prevent editing files #25

Closed jospoortvliet closed 4 years ago

jospoortvliet commented 4 years ago
  1. create a markdown or office file
  2. share the file with user X
  3. lock the file
  4. log in as user X and edit the file with Text or ONLYOFFICE - no problems... Which is a problem ;-)

Updated-from-16 local test instance of Nc 18.0.1, 0.8.1 version of the app.

ArtificialOwl commented 4 years ago

Ok, this is a known issue that is related to Text and onlyoffice and their way to sharing collaborated modification on a file throw a temporary file/buffer:

tl;dr: userB's edit are shared to userA that have writing access to the file.

The solution is to have those apps to check if the file is manually/temporary locked: https://github.com/nextcloud/server/pull/18080

ArtificialOwl commented 4 years ago

(i am closing the issue as this cannot be done from the files_lock app, but have to be implemented in any collaborating app)