search

nextcloud / files_lock

GNU Affero General Public License v3.0
25 stars 8 forks source link

Potential Logic Issue in GetLocksOlderThan Methods Data Retrieval. #264

Open zhiqi-23 opened 6 months ago

zhiqi-23 commented 6 months ago

The GetLocksOlderThan (int $timeout) method cannot retrieve data. The 149 lines of this method are the conditions for data query, which cannot retrieve data. Because "$timeout" is the set time (in minutes), and the creation field in the files_lock data table is a unix timestamp, a 10 digit integer number$ Timeout * 60 is impossible to exceed the value of the creation field, which means that data cannot be retrieved. Is there a problem with this logic.

AT-StephenDetomasi commented 1 month ago

That looks like 27.0.x code but I am seeing this issue on 29.0.x as well.