Closed rullzer closed 4 years ago
Interface-wise, this is what I talked about with Frank and further specified then:
I had a quick look and this should all be possible with the existing fileList. @daita Please ping me once https://github.com/daita/files_lock/issues/2 is done as I would then use the existing propfind in the files app to fetch the locking information and display it.
We show an indicator in the list entry about it being locked. I'd say a lock icon somehow overlaid on one corner of the menu icon.
What do you mean by corner of the menu icon? Maybe you can do a quick mockup?
Just a reminder, PROPFIND will be not be efficient resource wise. There is no way to have a 'fix/static' parent Id (Id of the folder that contains the file) as during a share, the parent folder can be different from one user to another. Meaning there is no point to store the Id of the current folder when locking a file.
The only efficient way to check which file of a folder is locked or not will be to have the current list of files of a folder, and send a request to my table to check which file from this list is locked.
@rullzer, your point on that one ?
should be ok, need a way to refresh the display on lock/unlock
@juliushaertl this is what the UI could look like, .icon-password
combined with the menu icon:
This seems a great first simple version before we overengineer the interface, with all the other info inside the actions menu. Possible further steps:
What do you think?
Alternatively, if that is possible to combine with sharing, we could show the avatar of the person who locked it instead of the sharer, and show the lock icon overlaid there? Then it goes to sharing, and we have the locking info there?
That would be more nicely integrated, but not sure if it’s easy to pull off @juliushaertl?
Would it be possible to limit the 'Lock File' entry in the ActionMenu to files not to files+folder ?
Using https://github.com/daita/files_lock/issues/2
We should show the locked state and actions in the webui @juliushaertl