Closed juliushaertl closed 1 year ago
Happens on routes that do not match the /remote.php/dav/files/userid/... pattern, e.g. address books, which we should rather block then even earlier for locking.
Another trace from public share links:
"exception": {
"Exception": "Error",
"Message": "Call to a member function getUID() on null",
"Code": 0,
"Trace": [
{
"file": "/var/www/html/apps/files_lock/lib/DAV/LockBackend.php",
"line": 153,
"function": "getFileFromUri",
"class": "OCA\\FilesLock\\Service\\FileService",
"type": "->"
},
{
"file": "/var/www/html/apps/files_lock/lib/DAV/LockBackend.php",
"line": 75,
"function": "getFileFromUri",
"class": "OCA\\FilesLock\\DAV\\LockBackend",
"type": "->"
},
{
"file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Locks/Plugin.php",
"line": 141,
"function": "getLocks",
"class": "OCA\\FilesLock\\DAV\\LockBackend",
"type": "->"
},
{
"file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Locks/Plugin.php",
"line": 415,
"function": "getLocks",
"class": "Sabre\\DAV\\Locks\\Plugin",
"type": "->"
},
{
"file": "/var/www/html/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
"line": 89,
"function": "validateTokens",
"class": "Sabre\\DAV\\Locks\\Plugin",
"type": "->",
"args": [
"*** sensitive parameters replaced ***"
]
},
{
"file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
"line": 1448,
"function": "emit",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
"line": 466,
"function": "checkPreconditions",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
"line": 253,
"function": "invokeMethod",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/var/www/html/3rdparty/sabre/dav/lib/DAV/Server.php",
"line": 321,
"function": "start",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/var/www/html/apps/dav/appinfo/v1/publicwebdav.php",
"line": 113,
"function": "exec",
"class": "Sabre\\DAV\\Server",
"type": "->"
},
{
"file": "/var/www/html/public.php",
"line": 80,
"args": [
"/var/www/html/apps/dav/appinfo/v1/publicwebdav.php"
],
"function": "require_once"
}
],
"File": "/var/www/html/apps/files_lock/lib/Service/FileService.php",
"Line": 109,
"CustomMessage": "--"
}
}
We're affected by the issue: It results in not being able to create or move files on public link shares, so we had to disable the files_lock app temporarily, until the issue is resolved.
While the exception is handled the errors is still logged by the file system method