Closed ArtificialOwl closed 2 years ago
strange that litmus fails:
3. put_get............... FAIL (GET of `/remote.php/dav/files/admin/litmus/res' failed: 500 Internal Server Error)
was that there before ?
@ArtificialOwl can you investigate the failure or check if related at all with your change ?
from what I see on master CI was green recently: https://github.com/nextcloud/files_lock/actions/runs/2532691131
so it's likely that this PR breaks something but it's not obvious
@ArtificialOwl please investigate the failure or find help
@ArtificialOwl please investigate the failure or find help
Were not able myself to locally reproduce the issue with litmus,
looks like /rebase
on master
was enough
So, in case of no user session, this will throw an
Exception
instead ofThrowable
, which is then ignored bygetLocks()
I am not a huge fan of ignoring locks, but it seems to happens only when upload a new file. Also, this works because we only allow
lock
on Files and not on Folder (parent).It seems to not affect the good functioning of the app in the case of creating a new file on a public folder. This is the logs when someone tries to upload a new file on a public folder over a locked existing file (same name, locked by internal user)