[Bug]: New version of an existing file cant be uploaded while the file is locked

InservNologin commented 2 years ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

When a file is locked and you have to upload a new version of the same file, you´ve to unlock it and upload the new version when before the user who blocked it could overwrite it while being blocked

Captura de pantalla de 2022-07-06 12-27-09

Steps to reproduce

A file exists
File is locked while editing
Upload the file again edited
Failed to upload the new version of the file

Expected behavior

The file should be overwritten by the user who blocked it when a new version is uploaded

Installation method

Manual installation

Operating system

RHEL/CentOS

PHP engine version

PHP 7.4

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

[ ] Default user-backend (database)
[X] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

--

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

szaimen commented 2 years ago

Cc @juliushaertl @ArtificialOwl @CarlSchwan

juliusknorr commented 2 years ago

What kind of file is this and did you manually lock it or did you use and editor that locks automatically on the file?

InservNologin commented 2 years ago

Its with any type of file. The file is locked manually

juliusknorr commented 2 years ago

Nextcloud and app versions would also be interesting. I cannot reproduce that with the latest release.

marcotrevisan commented 2 years ago

May #73 be related?

danir-de commented 2 years ago

Files might get locked by accessing them via Apps over WebDAV and rendering these workflows unusable.

This becomes a problem when editing files via WebDAV, as seen here: https://github.com/allotropia/nextcloud_files_libreoffice_edit/issues/16

Since the problem is part of the files_lock mechanic, this needs to be addressed here.

nextcloud / files_lock