nextcloud / files_pdfviewer

:book: A PDF viewer for Nextcloud
GNU Affero General Public License v3.0
91 stars 43 forks source link

Nextcloud 29.0.9: `files_pdfviewer-public.js` are missing and PDF documents can't be opened #1080

Closed mritzmann closed 3 days ago

mritzmann commented 2 weeks ago

How to use GitHub


Steps to reproduce

  1. Update Nextcloud to version 29.0.9
  2. Open any PDF

Expected behaviour

The PDF is displayed in the browser.

Actual behaviour

The PDF is not displayed in the browser, only offered for download.

Server configuration

Web server: Nginx

Database: MariaDB

PHP version: 8.2.2

Nextcloud version: 29.0.9

List of activated apps ``` $ php ~/www/occ app:list Enabled: - activity: 2.21.1 - cloud_federation_api: 1.12.0 - dav: 1.30.1 - federatedfilesharing: 1.19.0 - files: 2.1.1 - files_pdfviewer: 2.10.0 - files_sharing: 1.21.0 - files_trashbin: 1.19.0 - files_versions: 1.22.0 - groupfolders: 17.0.5 - impersonate: 1.16.0 - logreader: 2.14.0 - lookup_server_connector: 1.17.0 - notifications: 2.17.0 - oauth2: 1.17.1 - password_policy: 1.19.0 - previewgenerator: 5.6.0 - provisioning_api: 1.19.0 - richdocuments: 8.4.8 - serverinfo: 1.19.0 - settings: 1.12.0 - sharebymail: 1.19.0 - text: 3.10.1 - theming: 2.4.0 - twofactor_backupcodes: 1.18.0 - twofactor_totp: 11.0.0-dev - viewer: 2.3.0 - workflowengine: 2.11.0 Disabled: - admin_audit: 1.19.0 - bruteforcesettings: 2.9.0 - circles: 29.0.0-dev (installed 0.16.3) - comments: 1.19.0 (installed 1.6.0) - contactsinteraction: 1.10.0 (installed 1.0.0) - dashboard: 7.9.0 (installed 7.0.0) - encryption: 2.17.0 - federation: 1.19.0 (installed 1.6.0) - files_downloadlimit: 2.0.0 (installed 2.0.0) - files_external: 1.21.0 (installed 1.9.0) - files_reminders: 1.2.0 (installed 1.0.0) - firstrunwizard: 2.18.0 (installed 2.5.0) - nextcloud_announcements: 1.18.0 (installed 1.4.0) - photos: 2.5.0 (installed 2.0.1) - privacy: 1.13.0 (installed 1.0.0) - recommendations: 2.1.0 (installed 0.4.0) - related_resources: 1.4.0 (installed 1.1.0-alpha1) - support: 1.12.0 (installed 1.0.0) - survey_client: 1.17.0 (installed 1.3.0) - suspicious_login: 7.0.0 - systemtags: 1.19.0 (installed 1.6.0) - updatenotification: 1.19.1 (installed 1.5.0) - user_ldap: 1.20.0 - user_status: 1.9.0 (installed 1.0.1) - weather_status: 1.9.0 (installed 1.0.0) ```
Nextcloud configuration I can provide if necessary.

Browser

Browser name: Firefox

Browser version: 132.0.1 (aarch64)

Operating system: macOS 14.7

mritzmann commented 2 weeks ago

According to nextcloud.log the file files_pdfviewer-public.js is missing:

{
    "reqId": "hisLNxFNFjl13wRNglUg",
    "level": 3,
    "time": "2024-11-07T13:59:13+00:00",
    "remoteAddr": "**",
    "user": "--",
    "app": "jsresourceloader",
    "method": "GET",
    "url": "/index.php/s/**",
    "message": "Could not find resource files_pdfviewer/js/files_pdfviewer-public.js to load",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:132.0) Gecko/20100101 Firefox/132.0",
    "version": "29.0.9.2",
    "data": {
        "app": "jsresourceloader"
    }
}

And indeed, the file is missing in Nextcloud 29.0.9.

Nextcloud 29.0.8:

$ wget https://download.nextcloud.com/server/releases/nextcloud-29.0.8.zip
$ unzip -l nextcloud-29.0.8.zip | grep files_pdfviewer-public.js
    79936  2024-10-10 11:13   nextcloud/apps/files_pdfviewer/js/files_pdfviewer-public.js.map
    19184  2024-10-10 11:13   nextcloud/apps/files_pdfviewer/js/files_pdfviewer-public.js
     1683  2024-10-10 11:13   nextcloud/apps/files_pdfviewer/js/files_pdfviewer-public.js.LICENSE.txt

Nextcloud 29.0.9:

$ wget https://download.nextcloud.com/server/releases/nextcloud-29.0.9.zip
$ unzip -l nextcloud-29.0.9.zip | grep files_pdfviewer-public.js
solracsf commented 2 weeks ago

Seems to affect 29.0.9 only. Both 30.0.2 and 28.0.12 seems OK.

EDIT: Confirmed, https://github.com/nextcloud/files_pdfviewer/pull/1076 is the cause (files were deleted). Cc @szaimen

szaimen commented 2 weeks ago

A potential fix is in https://github.com/nextcloud/files_pdfviewer/pull/1081

prghix commented 2 weeks ago

me affected as well. 29.0.9.

solracsf commented 2 weeks ago

A potential fix is in #1081

Yeah this will fix it. 👍 For those affected, you'll have to wait for v29.0.10.

szaimen commented 2 weeks ago

Fixed via https://github.com/nextcloud/files_pdfviewer/pull/1081

Kieltux commented 1 week ago

Local workaround: I copied the files_pdfview directory from 29.0.8 into 29.0.9.

Dennis1993 commented 1 week ago

I copied the files in apps/files_pdfviewer/js too and it works now :)

Githopp192 commented 1 week ago

same: nc 29.0.9, PHP 8.3

I copied the files in apps/files_pdfviewer/js too and it works now :)

yes, workaround is working - copied from backup: cp -p ...backup/apps/files_pdfviewer/js/files* ..../apps/files_pdfviewer/js

You need to re-login to make it to work

susnux commented 3 days ago

Will be resolved with 29.0.10 scheduled for begin of December