nextcloud / files_photospheres

Nextcloud app for viewing Google PhotoSphere 360° images (panorama-images)
GNU Affero General Public License v3.0
29 stars 2 forks source link

`An error occured while trying to read xmp-data: Share not found` in shared subfolders with special characters #114

Closed raph-topo closed 1 year ago

raph-topo commented 1 year ago

Hello, Considering a public share link, showing up as the home icon. When trying to open a photosphere in a subfolder which includes a +, & or ; in its name, photoshere does not work, saying An error occured while trying to read xmp-data: Share not found. Photospheres in subfolders containing spaces, - ' ! ( do work fine. I only found +, & or ; to be concerned for. This makes me think it is related to HTML (un)escaping. This only applies to public shares, the same subfolders create no issue when browsing as logged in user.

R0Wi commented 1 year ago

Thanks for reporting this. I think you might be right and we're currently missing the proper URL encoding. Will have a closer look at this

R0Wi commented 1 year ago

Sould be fixed by https://github.com/nextcloud/files_photospheres/commit/9db769bc63e3a072b562e0a342789c127942ac01. Please update to v1.26.2, which will be available soon.

raph-topo commented 1 year ago

I do confirm this is fixed, congrats and many thanks!