nextcloud / files_photospheres

Nextcloud app for viewing Google PhotoSphere 360° images (panorama-images)
GNU Affero General Public License v3.0
29 stars 2 forks source link

The "close" button in the upper right corner has no function. #143

Closed AlBundy00 closed 4 months ago

AlBundy00 commented 5 months ago

As the subject says. When I click on the X upper right nothing happens. Only way to leave it close the brower tab. I'm using Chrome. Also tried with Edge. Same thing.

laurensbl commented 5 months ago

Same here. Firefox. Weird thing is that sometimes it does work, mostly directly after opening an image. It then stops functioning after dragging the view around. But... sometimes even after dragging around it keeps working. Mostly not, however.

R0Wi commented 5 months ago

I need to have a closer look into this as soon as time permits. I'm suspecting some problems in the code related to the removal of the viewers iframe. Not sure why this only happens "sometimes" but might be a race condition. Will keep you posted ...

AlBundy00 commented 5 months ago

Not a big deal.

Will keep you posted ... Thanks a lot!

R0Wi commented 5 months ago

Could you please share which Nextcloud- and App-version you're using?

laurensbl commented 5 months ago

Just checked, behavior occurs with Nextcloud 28.0.6 en app version 1.28.1.

Edit: Updated to 1.28.2, problem still exists.

R0Wi commented 5 months ago

Thanks for the feedback. v1.28.2 did not yet fix the problem.

Would you be so kind and try the artifact from https://github.com/nextcloud/files_photospheres/actions/runs/9378221736/artifacts/1569478425 ? I applied a fix there which seems to work for me and I would love to hear your feedback.

laurensbl commented 5 months ago

Tried the artifact and the button seems to work fine now, Tried with several spheres on different locations (local and on external storage), didn't get it to fail.

R0Wi commented 4 months ago

Thanks for the feedback. I incorporated the changes into v1.28.3 👍

AlBundy00 commented 4 months ago

Close button now working.

Thanks a lot for your work!