nextcloud / files_photospheres

Nextcloud app for viewing Google PhotoSphere 360° images (panorama-images)
GNU Affero General Public License v3.0
29 stars 2 forks source link

Establish CI with Travis/Scrutinizer/CodeCov #29

Closed R0Wi closed 4 years ago

R0Wi commented 5 years ago

I would really like to establish a CI pipeline with automatic builds, testing and deployment. Unfortunately i can't add the repository to Travis/Scrutinizer/CodeCov because i'm not the owner. Let's say i would like to setup a similar pipeline like other apps (like https://github.com/nextcloud/files_pdfviewer) do.

@LukasReschke @MorrisJobke is there a way to accomplish this?

R0Wi commented 4 years ago

@skjnldsv any help would be appreciated please.

skjnldsv commented 4 years ago

Hey :) Travis is enabled for the whole company, you can just add a travis config file and it will trigger We're also using our own drone servers, so you might want to consider using drone as well, as it offers more versatility with your tests :)

R0Wi commented 4 years ago

Thanks for your feedback. Is travis also enabled on branches so i can test it on a test branch? I'll take a look at drone , too :-)

skjnldsv commented 4 years ago

yes, create a pull request and you'll get your github feedback :)

R0Wi commented 4 years ago

@skjnldsv thanks for you help. I did a setup for drone on #42 but it doesn't run automatically. The config from https://drone.nextcloud.com/nextcloud/files_photospheres/settings says "activate repository" but if i click the button i get "There was a problem enabling your repository. Not Found.". Am i missing something here?

skjnldsv commented 4 years ago

Hey ! In the meantime we tried to move away from drone as much as we can, because it takes forver now :( We have too much tests running on our servers ^^ You can see your github actions examples in the app-tutorial repostory though, this is blazing fast and awesomely simple! :D

https://github.com/nextcloud/app-tutorial/tree/master/.github/workflows

skjnldsv commented 4 years ago

i click the button i get "There was a problem enabling your repository. Not Found.". Am i missing something here?

I guess you need the permissions to do so :see_no_evil: Let me activate for you!

R0Wi commented 4 years ago

Thanks for your great support :-) I'll have a look at the github actions. By the way: is it possible to add me as "administrator" for this repository? Because i can't configure any merge-checks etc. which is quite annoying :-/

skjnldsv commented 4 years ago

Done, sorry about that, good enough?

R0Wi commented 4 years ago

Perfect, thanks so much for your support :-D

skjnldsv commented 4 years ago

You're very welcome! :hugs:

R0Wi commented 4 years ago

@skjnldsv may i just annoy you one last time: i did a setup with GitHub Actions (very nice by the way, thanks) and i would like store some secrets (app key) in the Secret tab of the repo-settings for automatic signing and deployment. Unfortunately i do only have the rights to see tabs Options and Interaction limits. Is it possible to activate the tabs Secrets, Branches and Webhooks, too please?

skjnldsv commented 4 years ago

You're not annoying me :) Should be good now?

R0Wi commented 4 years ago

Perfect, thanks a lot :-)