[Bug]: Contex menu on shared folders shows more actions than allowed when checkbox is ticked

caco3 commented 2 years ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

When creating a shared folder and providing a link to it, it is treated read-only by default. The 3-dot actions on the top and right side of the file then only show "download" (as expected). How ever when ticking the files checkbox and then doing a right-click to the file, a context menu opens and showing more actions than allowed, eg. "delete" and "move".

grafik grafik grafik

Steps to reproduce

create a folder and share it (default settings => read only)
open the link to the shared folder
right click on a file
validate the context menu does not show "delete"
tick the checkbox the of the file
right click on the file again

Expected behavior

Under any condition must only the allowed actions be shown

Installation method

Manual installation

Operating system

Other

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

[X] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

The current PHP memory limit is below the recommended value of 512MB.
{
    "system": {
        "maintenance": false,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "owncloud.***.ch",
            "www.***.ch",
            "***.ch",
            "cloud.***.ch"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/cloud.***.ch",
        "version": "24.0.2.1",
        "installed": true,
        "dbtype": "mysql",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "theme": "",
        "loglevel": 0,
        "updater.release.channel": "stable",
        "app_install_overwrite": [
            "defaultlinkopen",
            "drawio",
            "sharerenamer"
        ],
        "trashbin_retention_obligation": "auto, 180",
        "htaccess.RewriteBase": "\/"
    }
}

List of activated Apps

Enabled:
  - activity: 2.16.0
  - admin_audit: 1.14.0
  - apporder: 0.15.0
  - calendar: 3.4.1
  - circles: 24.0.0
  - cloud_federation_api: 1.7.0
  - contacts: 4.1.1
  - contactsinteraction: 1.5.0
  - dav: 1.22.0
  - drawio: 1.0.3
  - external: 4.0.0
  - federatedfilesharing: 1.14.0
  - files: 1.19.0
  - files_pdfviewer: true
  - files_rightclick: 1.3.0
  - files_sharing: 1.16.2
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - files_videoplayer: 1.13.0
  - logreader: 2.9.0
  - lookup_server_connector: 1.12.0
  - nextcloud_announcements: 1.13.0
  - notifications: 2.12.0
  - oauth2: 1.12.0
  - onlyoffice: 7.5.2
  - password_policy: 1.14.0
  - photos: 1.6.0
  - privacy: 1.8.0
  - provisioning_api: 1.14.0
  - recommendations: 1.3.0
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - support: 1.7.0
  - survey_client: 1.12.0
  - text: 3.5.1
  - theming: 1.15.0
  - twofactor_backupcodes: 1.13.0
  - updatenotification: 1.14.0
  - user_status: 1.4.0
  - viewer: 1.8.0
  - weather_status: 1.4.0
  - workflowengine: 2.6.0
Disabled:
  - accessibility: 1.6.0
  - comments: 1.10.0
  - dashboard: 7.0.0
  - encryption
  - federation: 1.10.1
  - files_external: 1.11.1
  - firstrunwizard: 2.9.0
  - serverinfo: 1.10.0
  - systemtags: 1.10.0
  - user_ldap: 0.1

Nextcloud Signing status

Technical information
=====================
The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results
=======
- core
    - EXTRA_FILE
        - apps.txt

Raw output
==========
Array
(
    [core] => Array
        (
            [EXTRA_FILE] => Array
                (
                    [apps.txt] => Array
                        (
                            [expected] => 
                            [current] => 49aee9dd2dacc7a87cbee052afc51a5f66517ed5ed7fbf5aef4a81faf63f11acf298dcb63e0624b04269fa7779bb72b6df7d40616b39ee0d6c736680c0a962ea
                        )

                )

        )

)

Nextcloud Logs

No response

Additional info

Tested with following browsers:

Firefox, Linux
Chrome, Linux
Chromium, Linux
Chrome, Windows

caco3 commented 2 years ago

This is most likely a duplicate of https://github.com/nextcloud/files_rightclick/issues/113 How ever I keep it open as it still happens on the latest version and it contains more details.

szaimen commented 1 year ago

Hi, this PR might have fixed the bug: https://github.com/nextcloud/files_rightclick/pull/152

nextcloud / files_rightclick