[Bug]: Nextcloud (22, 23, 24) Files : Inconsistent context menu (right-click) on "selected" trash items (+ "multiple selection" feature bug)

Jerome-Herbinet commented 2 years ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] Nextcloud Server is running on 64bit capable CPU, PHP and OS.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

When you right-click on an item placed in the recycle bin, the only choice is "Delete permanently". Already, in this case, something is missing; we should have :

Delete permanently
Restore

Then, if you select the item (by checking the selection checkbox), it's worse because you find in the contextual menu all the choices you would have if the file was not in the recycle bin:

Unselect
Move or copy
Download
Select file range
Delete
Tags
Restore
Delete permanently

You should only have the following options:

Unselect
Select file range
Delete permanently
Restore

I also notice that the "Select file range" feature does not work in the recycle bin anyway, so either fix it or remove the select (or multiple select) feature in the recycle bin.

I have seen this on Nextcloud 22, 23 and 24.

Steps to reproduce

Delete some files and / or folders
Go to "Deleted files"
Compare the right-click menu between the 2 following contexts :
- When the deleted element is not selected (IMO, "Restore" is missing in this context)
- When the deleted element is selected (too many options ... just like if the deleted element wasn't deleted)

Expected behavior

We should have this if no element is selected :

Delete permanently
Restore

We should have this if one or several element(s) is/are selected :

Unselect
Select file range
Delete permanently
Restore

Note : The "Select file rage" (multiple selection) feature doesn't work in "Deleted files".

Installation method

Web installer on a VPS or web space

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

[X] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

{
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "nextcloud.mydomain.fr"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "dbtype": "mysql",
    "version": "24.0.4.1",
    "updatechecker": true,
    "overwrite.cli.url": "https:\/\/nextcloud.mydomain.fr",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "filelocking.enabled": true,
    "filelocking.ttl": 3600,
    "default_language": "fr",
    "default_locale": "fr_FR",
    "default_phone_region": "ISO3166-2",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpmode": "smtp",
    "mail_sendmailmode": "smtp",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpauthtype": "LOGIN",
    "mail_smtpauth": 1,
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpport": "25",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "memcache.local": "\\OC\\Memcache\\Redis",
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": 6379
    },
    "maintenance": false,
    "theme": "",
    "loglevel": 2,
    "updater.release.channel": "stable",
    "app_install_overwrite": [
        "occweb"
    ]
}

List of activated Apps

Enabled:
 - accessibility: 1.10.0
 - activity: 2.16.0
 - announcementcenter: 6.3.1
 - apporder: 0.15.0
 - bruteforcesettings: 2.4.0
 - calendar: 3.4.2
 - cfg_share_links: 2.0.0
 - circles: 24.0.1
 - cloud_federation_api: 1.7.0
 - comments: 1.14.0
 - contacts: 4.2.0
 - contactsinteraction: 1.5.0
 - dashboard: 7.4.0
 - dav: 1.22.0
 - deck: 1.7.1
 - external: 4.0.0
 - federatedfilesharing: 1.14.0
 - federation: 1.14.0
 - files: 1.19.0
 - files_accesscontrol: 1.14.0
 - files_automatedtagging: 1.14.0
 - files_external: 1.16.1
 - files_linkeditor: 1.1.11
 - files_lock: 24.0.1
 - files_pdfviewer: 2.5.0
 - files_readmemd: 1.2.2
 - files_rightclick: 1.3.0
 - files_sharing: 1.16.2
 - files_trashbin: 1.14.0
 - files_versions: 1.17.0
 - files_videoplayer: 1.13.0
 - firstrunwizard: 2.13.0
 - groupfolders: 12.0.1
 - guests: 2.2.0
 - impersonate: 1.11.0
 - jitsi: 0.15.0
 - logreader: 2.9.0
 - lookup_server_connector: 1.12.0
 - metadata: 0.16.0
 - nextcloud_announcements: 1.13.0
 - notes: 4.5.0
 - notifications: 2.12.0
 - oauth2: 1.12.0
 - occweb: 0.1.0
 - password_policy: 1.14.0
 - passwords: 2022.6.20
 - phonetrack: 0.7.0
 - photos: 1.6.0
 - privacy: 1.8.0
 - provisioning_api: 1.14.0
 - quota_warning: 1.14.0
 - recommendations: 1.3.0
 - richdocuments: 6.2.0
 - richdocumentscode: 22.5.502
 - serverinfo: 1.14.0
 - settings: 1.6.0
 - sharebymail: 1.14.0
 - sharerenamer: 3.0.1
 - spreed: 14.0.4
 - support: 1.7.0
 - survey_client: 1.12.0
 - systemtags: 1.14.0
 - text: 3.5.1
 - theming: 1.15.0
 - theming_customcss: 1.11.0
 - twofactor_backupcodes: 1.13.0
 - twofactor_email: 2.5.0
 - twofactor_nextcloud_notification: 3.4.0
 - twofactor_totp: 6.4.0
 - updatenotification: 1.14.0
 - user_status: 1.4.0
 - video_converter: 1.0.5
 - viewer: 1.8.0
 - weather_status: 1.4.0
 - welcome: 1.0.1
 - workflowengine: 2.6.0
Disabled:
 - admin_audit
 - duplicatefinder: 0.0.15
 - encryption
 - extract: 1.3.5
 - files_zip: 1.1.2
 - user_ldap

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Can be provided if necessary

Additional info

No response

elhananjair commented 1 year ago

I think this app is not getting updates or fixes anymore, this is sad.

Jerome-Herbinet commented 1 year ago

@nickvergessen can you tell me (confirm or not), as @elhananjair seams to think, that "files_rightclick" is a little abandoned ? Effectively, no more release since 2019, strange ? Can you tell us if this issue has to be moved to another project ?

nickvergessen commented 1 year ago

I don't know about the development. But the app is shipped, so no releases on the github repo, but you can see on the tags that it is still included https://github.com/nextcloud/files_rightclick/tags

elhananjair commented 1 year ago

@PVince81 @MorrisJobke @juliushaertl @NastuzziSamy @nickvergessen @Jerome-Herbinet I have checked the tags, and nextcloud_bot is adding some translations nothing else, there is no activity on this application from developers, no new features, and no bug fixes which means it's not maintained by nextcloud developers anymore.

Jerome-Herbinet commented 1 year ago

Thanks for your answer @elhananjair ; I'm waiting for some mentioned contributors to tell us where the “right click” feature is now developed, in order to move this issue to the right place.

nickvergessen commented 1 year ago

It's here. Just no further development done i guess.

Jerome-Herbinet commented 1 year ago

I understand your answer, but I find it difficult to understand.

Either the project is abandoned, which means that in a future version of Nextcloud, we are supposed to have no more contextual menu feature when right-clicking on files and folder, or it is necessarily maintained ... somewhere else, and this is the information I would like to have if it is the case.

nickvergessen commented 1 year ago

Either the project is abandoned, which means that in a future version of Nextcloud, we are supposed to have no more contextual menu feature when right-clicking on files and folder

I did not hear of a plan like this.

or it is necessarily maintained

We are a public open source thing. Anyone can try to fix it and help maintaining the app. I guess it does not have enough priority and therefore is not being worked on at the moment by the company, but anyone can try to dive into the bug and try to find the problem and then update the app with a fix? That being said, this app was never maintained by the company, but https://github.com/NastuzziSamy made a nice open source contribution. In the meantime he co-founded another company (judging from the github bio), so might just be out of free time for this.

Jerome-Herbinet commented 1 year ago

I understand very well what you are saying, and totally agree with you, being myself a contributor and convinced user of Open Source software 😉

The only thing I would have liked is a clearer indicator like "deprecated", or "no longer maintained", or "now part of the XXX project" ... or even sometimes, "we are looking for volunteer staff to keep the project going".

All this does not in any way distort the spirit of Open Source, and allows everyone to save a little time, or to know what to expect, even if it means investing more time if you have the required skills.

nickvergessen commented 1 year ago

we are looking for volunteer staff to keep the project going

I guess that is it, the question is where to put this and who should.

Jerome-Herbinet commented 1 year ago

we are looking for volunteer staff to keep the project going

I guess that is it, the question is where to put this and who should.

The Readme.md should be the right place to indicate the project's health.

elhananjair commented 1 year ago

@nickvergessen @juliushaertl I just wanted to make it clear that this app is not getting any updates, and in my opinion users must know, however, there is no indication for that just like @Jerome-Herbinet suggested maybe on Readme.md it would be really helpful to at least let the users know.

nickvergessen commented 1 year ago

Feel free to edit the ReadMe, doesn't need anyone from the pinged list to receive even more notifications.

PS sorry for my frustration, just drowning in notifications of things that are not my duty these days

szaimen commented 1 year ago

Hi, this PR might fix the bug: https://github.com/nextcloud/files_rightclick/pull/157

nextcloud / files_rightclick