nextcloud / files_zip

Allow zipping files directly on your NC server
GNU Affero General Public License v3.0
20 stars 3 forks source link

After zipping a folder, it reports that it is "created in a public folder" (but it is not in such a folder) #290

Open Omemanti opened 2 weeks ago

Omemanti commented 2 weeks ago

After creating a zip file, it reports in properties as well in the notification email that the zipfile was created in a public folder After checking, it does not seem to be in a public or shared folder.

Steps to reproduce

  1. User zipper in nextcloud to compress a folder
  2. It reports in properties as well in the notification email that the zipfile was created in a public folder

Expected behaviour

When created in a non public folder, the notification should not tell that it was done so.

Also, I don't have proof that it is in a public folder, but for the sake of certainty, it should be checked if it definitely is not creating a public folder. (in case i'm not proficient enough to find if it is creating a public folder.)

Actual behaviour

It sends out a notification via email that the file was created in a public folder.

Server configuration

Web server: Docker

Database: Maria

PHP version: 8.2.24

**Nextcloud version: 30.0.0

Image

Omemanti commented 2 weeks ago

Thread made on : https://help.nextcloud.com/t/email-file-zip-was-created-in-a-public-folder/206611/3

message seems to be created at : https://github.com/nextcloud/server/blob/03d553f6916b1c5120bbcf5e1bbf50e0aabce6f9/apps/files/lib/Activity/Provider.php#L179

joshtrichards commented 1 day ago

Reproduced.

I believe it's originating from here:

https://github.com/nextcloud/activity/blob/3830230bce3673007cd38477efc0e78eb8eda0b5/lib/FilesHooks.php#L67-L82

EDIT: Maybe be related to recent change:

nextcloud/activity#1745 nextcloud/server#46945