search

nextcloud / flow

Nextcloud Flow Engine
https://apps.nextcloud.com/apps/flow
GNU Affero General Public License v3.0
11 stars 1 forks source link

Add reuse compliance #22

Closed AndyScherzinger closed 2 weeks ago

AndyScherzinger commented 2 weeks ago

Open issue:

MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:

The following files have no licensing information:

This should be fixed by running compile due to the added license file generation via https://github.com/nextcloud/flow/pull/22/commits/50298d215020b18c9d181fca0d73625460a1257d however this doesn't work on plain Windows, so I couldn't run it. Maybe you folks can do and check if it creates the right files and turns the check green 🤞

I also replaced the windmill icon with the Flow icon via https://github.com/nextcloud/flow/pull/22/commits/ff5c170f9a5a6a46c00e2b5ff7216eae308af843

bigcat88 commented 2 weeks ago

@AndyScherzinger should we add "ex_app/js/flow-main.js" file to the ignore list?

In Talk app they are ignored: https://github.com/nextcloud/spreed/blob/fa7b7afeac0f8e6d3ad563c708fd8d4ef601c5f3/REUSE.toml#L14-L18

Also from CI we now have these complains from REUSE:

# MISSING LICENSES

'BSD-2-Clause' found in:
* ex_app/js/flow-main.js
'BSD-3-Clause' found in:
* ex_app/js/flow-main.js
'GPL-3.0-or-later' found in:
* ex_app/js/flow-main.js
'ISC' found in:
* ex_app/js/flow-main.js
'MPL-2.0' found in:
* ex_app/js/flow-main.js
'mit' found in:
* ex_app/js/flow-main.js
AndyScherzinger commented 2 weeks ago

No, we should add them 👍 I simply need to run. reuse download -- all

Talk is lacking this since the app got migrated to SPDX headers before Ferdinand build the plugin that can extract license data in an SPDX format. So Talk went for that shortcut/hack. I'll fix that in a follow up for Talk 👍.

AndyScherzinger commented 2 weeks ago

@bigcat88 fixed the reuse issues 👍

https://github.com/nextcloud/flow/pull/22/commits/abc65d45494f2245de9b608394c2133e16c65c88 should be the result of a new compile (which won't work on windows...) and https://github.com/nextcloud/flow/pull/22/commits/5273f1b0a23f754c569999338141b3a26139006b should have been part of the compile, since you didn't commit it I suspect a bug in the plugin from @susnux or you didn't commit that symlink?

In any way, check turns green now 😃

bigcat88 commented 2 weeks ago

Thank you Andy, then let's merge.