search

nextcloud / flow

Nextcloud Flow Engine
https://apps.nextcloud.com/apps/flow
GNU Affero General Public License v3.0
11 stars 1 forks source link

Improvements to u/admin/exapp_resource #7

Open Lumpiness opened 1 month ago

Lumpiness commented 1 month ago

I propose to make changes to the main.py.

Add baseUrl from the NEXTCLOUD_URL container environment variable. Then u/admin/exapp_resource will correspond to the resource from Windmill Hub.

Add the AA_VERSION, APP_ID, APP_VERSION container environment variables to the u/admin/exapp_resource resource. Then the header declarations in the Windmill Hub integrations will look something like this:

"AA-VERSION": ncResource.aaVersion,
"EX-APP-ID": ncResource.appId,
"EX-APP-VERSION": ncResource.appVersion

But will need to think through a mechanism for updating the u/admin/exapp_resource resource when updating the application.

bigcat88 commented 1 month ago

Good idea, I like it.

I'll be working on the next version next week, I'll think about it.

bigcat88 commented 1 month ago

Add baseUrl from the NEXTCLOUD_URL container environment variable.

Add the AA_VERSION, APP_ID, APP_VERSION container environment variables to the u/admin/exapp_resource resource.

This is planned for version 1.1.0, in two weeks will make a PR for this.

But will need to think through a mechanism for updating the u/admin/exapp_resource resource when updating the application.

There is already such code present, just need to extend it to handle the new values that will be added.