search

nextcloud / forms

📝 Simple form & survey app for Nextcloud
https://apps.nextcloud.com/apps/forms
GNU Affero General Public License v3.0
324 stars 98 forks source link

Add QR-Code for Share Links #2162

Closed Himmelxd closed 4 months ago

Himmelxd commented 6 months ago

Closes #1606 at least supposed to image

Chartman123 commented 6 months ago

@Himmelxd thanks for this PR :) I added some comments on the code

Himmelxd commented 6 months ago

Thank you for your review and great comments :D

susnux commented 5 months ago

PS: My code suggestions are only to show what I meant, they are not tested and need some refactoring ;)

Chartman123 commented 4 months ago

@Himmelxd to fix the remaining Lint/Prettier errors, you should run npx prettier . --write in your Forms directory. This will reformat all files according to the prettier rules. Instead of the . you can also specify the failing files and only reformat them.

Depending on your editor, there are also some extensions that allow formatting single files directly.

susnux commented 4 months ago

@Himmelxd Thank you very much, awesome work :rocket: Hope to see more contributions in the future!