nextcloud / forms

📝 Simple form & survey app for Nextcloud
https://apps.nextcloud.com/apps/forms
GNU Affero General Public License v3.0
316 stars 97 forks source link

Data source for the Analytics App #2195

Closed Rello closed 2 months ago

Rello commented 3 months ago

This pull adds a data source to report on forms with Analyitcs


Data source selection

Bildschirmfoto 2024-06-01 um 17 43 25


Single report

Bildschirmfoto 2024-06-01 um 17 46 31


Dashboard

Bildschirmfoto 2024-06-01 um 17 48 57

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 45.17%. Comparing base (e019081) to head (0530cd1). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2195 +/- ## ============================================ - Coverage 45.95% 45.17% -0.79% - Complexity 797 811 +14 ============================================ Files 65 67 +2 Lines 3066 3119 +53 ============================================ Hits 1409 1409 - Misses 1657 1710 +53 ```
susnux commented 3 months ago

CI is failing a lot (PHP code style, missing stubs for psalm, missing unit tests), please fix this :)

Also cc @Chartman123, what do you think about this?

Chartman123 commented 3 months ago

@susnux if this doesn't come with any problems when the Analytics app isn't installed, I'd be fine with it.

Rello commented 3 months ago

@Chartman123 I just did another test on my side - all clean. no nextcloud.log happy for an other retest

...we only need to find a way for the psalm and the unit-tests...

Chartman123 commented 3 months ago

@Rello are you ready with this PR? Perhaps you could add some more unit tests, so that the Codecov workflows turn green, too 🙂

Before we merge this, also please do a rebase on current main and squash all the commits into one single commit.

Rello commented 3 months ago

Hi @Chartman123 I will retest one more time and post an update here. regarding unit tests, I would need assistant. I never did these in the past as the dev-capacity is pretty limited...

Chartman123 commented 3 months ago

@Rello please don't merge the main branch into your branch and use git rebase instead :)

Rello commented 3 months ago

@Rello please don't merge the main branch into your branch and use git rebase instead :)

Hi, any hint on the background? I was always doing this until now. but open to learn something better. Tx!

Chartman123 commented 3 months ago

Rebasing results in a cleaner commit history, when we merge the changes back into our main :)

Rello commented 2 months ago

@Chartman123 @susnux all tests are green - besides the codecov part and I have no idea how to solve this. what do you suggest to do here?

Rello commented 2 months ago

🙏🏻

Chartman123 commented 2 months ago

@susnux we should have squashed the commits into one single commit first... ;)