Closed Rello closed 2 months ago
Attention: Patch coverage is 0%
with 53 lines
in your changes missing coverage. Please review.
Project coverage is 45.17%. Comparing base (
e019081
) to head (0530cd1
). Report is 14 commits behind head on main.
CI is failing a lot (PHP code style, missing stubs for psalm, missing unit tests), please fix this :)
Also cc @Chartman123, what do you think about this?
@susnux if this doesn't come with any problems when the Analytics app isn't installed, I'd be fine with it.
@Chartman123 I just did another test on my side - all clean. no nextcloud.log happy for an other retest
...we only need to find a way for the psalm and the unit-tests...
@Rello are you ready with this PR? Perhaps you could add some more unit tests, so that the Codecov workflows turn green, too 🙂
Before we merge this, also please do a rebase on current main and squash all the commits into one single commit.
Hi @Chartman123 I will retest one more time and post an update here. regarding unit tests, I would need assistant. I never did these in the past as the dev-capacity is pretty limited...
@Rello please don't merge the main branch into your branch and use git rebase
instead :)
@Rello please don't merge the main branch into your branch and use
git rebase
instead :)
Hi, any hint on the background? I was always doing this until now. but open to learn something better. Tx!
Rebasing results in a cleaner commit history, when we merge the changes back into our main :)
@Chartman123 @susnux all tests are green - besides the codecov part and I have no idea how to solve this. what do you suggest to do here?
🙏🏻
@susnux we should have squashed the commits into one single commit first... ;)
This pull adds a data source to report on forms with Analyitcs
Data source selection
Single report
Dashboard