nextcloud / forms

📝 Simple form & survey app for Nextcloud
https://apps.nextcloud.com/apps/forms
GNU Affero General Public License v3.0
324 stars 98 forks source link

feat: Allow listening to form submissions via events and webhooks #2265

Closed marcelklehr closed 2 months ago

marcelklehr commented 3 months ago

requires Nextcloud 30

This will allow users of the upcoming windmill workflow automation app to trigger automations based on form submissions.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6b0f960). Learn more about missing BASE report. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2265 +/- ## ======================================= Coverage ? 36.16% Complexity ? 1014 ======================================= Files ? 70 Lines ? 3824 Branches ? 0 ======================================= Hits ? 1383 Misses ? 2441 Partials ? 0 ```
susnux commented 3 months ago

requires Nextcloud 30

So this can only be part of the next planned major version 5.0 as we still support Nextcloud 29 an 28, while there are already plans for 5.0 we still need to work on some features / technical dept.

marcelklehr commented 2 months ago

I removed the requirement of Nextcloud 30, so we can hopefully merge this sooner :pray:

Chartman123 commented 2 months ago

@marcelklehr nice :) please fix the errors, then we can merge it :)

Chartman123 commented 2 months ago

@come-nc @marcelklehr Can this be used to solve issues #1850, #1772, #1748, #1223 and/or #805?

susnux commented 2 months ago

Yes and no, this is about windmill webhooks based workflows. That allows to do even more than with Nextcloud flow but requires you to also host Windmill, so this is nothing that can be easily done on "plain" hosting.

Meaning the first 3 issues would I still consider feature requests, similar to the analytics integration - if someone wants to create an integration (and add proper tests) we could integrate that. The last one ... well the new windmill integration is called "flow" but that ticket is more about workflowengine flow which is the Nextcloud built-in alternative that does not require external API, maybe still something to consider but would also need work on our side.

only #1223 could be done with Nextcloud 30 due to the webhook_listeners app integrated with Nextcloud now. You should be able to register webhooks based on the forms submitted event. I did not test this yet, but probably something we could document and then close the request :)