search

nextcloud / forms

📝 Simple form & survey app for Nextcloud
https://apps.nextcloud.com/apps/forms
GNU Affero General Public License v3.0
318 stars 97 forks source link

Impossible to edit questions/answers with keyboard only after initial writing #416

Closed jancborchardt closed 11 months ago

jancborchardt commented 4 years ago
  1. Some a questions with some answers
  2. Now don’t use your mouse anymore
  3. Using the Tab key, try navigating using just your keyboard and edit the existing questions.

It’s not possible as you can not focus the titles or answers, and focusing them does not change it to editing mode.

@jotoeri @skjnldsv any idea how we can trigger that? We can for sure put tabindex="0" on each of the question and answer elements, but it needs to then trigger a switch to the edit view.

elioqoshi commented 2 years ago

This is an accessibility issue which blocks people with certain disabilities from using forms. I'd be glad to help if there is anything I can do.

susnux commented 1 year ago

Currently we use @click to enable the edit mode, I think we need an @focus additionally with @focusout to stop editing.

fcnjd commented 1 year ago

Hello, thank you for tracking this issue. I as a user would like to provide an additional task item: A part of editing questions is also to change the order. This as well isn't possible using only the keyboard, a mouse is required. It would be nice to have propperly labelled buttons for each question, which move it one position upwards or downwards accordingly.

Chartman123 commented 1 year ago

@fcnjd Re-ordering the questions is also already tracked as a separate issue and we're currently working on it :) #317

Chartman123 commented 12 months ago

@susnux @jancborchardt @jotoeri Provoking idea: What about always switching all fields to editable as long as we're in the edit view? This way we wouldn't have to deal with adding a focus trap to the non-input variants in the edit view.

jotoeri commented 12 months ago

Not so provoking, i'd say. I had that thought, too. Since we have the edit/submit now directly accessible, that would make several things much easier, if there is only the global edit mode. So +1 from my side. :)

susnux commented 12 months ago

I am not that sure about this, as it is quite nice to have a preview of the form while creating it. Its at least one of the nice UI features we have, don't you think so?

Chartman123 commented 12 months ago

Except for the multiple choice questions it's mostly no difference currently. Only the markdown fields will have a bigger difference between edit/view.

But on the other side I remember all the hassle about aligning the layout in edit/view modes everytime there are bigger design changes in the server core...

jotoeri commented 11 months ago

I am not that sure about this, as it is quite nice to have a preview of the form while creating it. Its at least one of the nice UI features we have, don't you think so?

It is, yes. But now you also have the 'preview' by the submit view, which is just 1 click away. And that 1 click on the other hand removes the necessity to click on every question separately to edit it. Maybe that even eases usage a bit. And then, that would remove the focus-trap complexity, would allow for proper (easier) accessibility with keayboard navigation, would reduce the jumping in edit mode (#434), ... 🤔

Chartman123 commented 11 months ago

nice to have a preview of the form while creating it.

@susnux I can imagine to at least have some kind of tabbed input field for the descriptions to directly see the markdown rendering just like for example here on Github.