search

nextcloud / fulltextsearch

🔍 Core of the full-text search framework for Nextcloud
https://apps.nextcloud.com/apps/fulltextsearch
GNU Affero General Public License v3.0
216 stars 51 forks source link

Update Runner.php to avoid "Force Quit" situation and allow the job to be finished #870

Open ferdiga opened 2 months ago

ferdiga commented 2 months ago

…o finish

This is obviously only a quick fix for those who prefer to get most files indexed and can live with the fact that some are not. Especially many pdf's won't be indexed anyhow unless ocrmypdf is installed and working. Hetzner does not provide ocrmypdf for performance reasons.

github-actions[bot] commented 1 month ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

ArtificialOwl commented 1 month ago

Hello,

is it really necessary ? the force quit is mainly here for timeout process

ferdiga commented 1 month ago

Force Quit solved only part of the problem especially having installed elastic on an external server and using a Hetzner service without access to log files. So no way to fix this economically as there was no feedback why the job failed.

IMO there must be a list of ALL errors for an index run and then the user or admin or skilled developer is needed to fix these in ONE go and not file by file as I assume that there will be a pattern of errors which can be fixed using a script.

second - even more problematic is described here https://github.com/nextcloud/fulltextsearch/issues/872

my "little" database with relative few images would need about a month to get indexed as indexing an image takes multiple minutes - not only ONE as described in this bug report.

On top - indexing image files modifies the file (obviously) and triggers an (unwanted and expensive in terms of transferred data) sync to nextcloud desktop clients.