search

nextcloud / fulltextsearch_elasticsearch

🔍 Use Elasticsearch to index the content of your Nextcloud
https://apps.nextcloud.com/apps/fulltextsearch_elasticsearch
GNU Affero General Public License v3.0
81 stars 30 forks source link

Authentication for ES8 added Closing #256 #261

Closed R0Wi closed 1 year ago

R0Wi commented 1 year ago

Fix for issues

Parses the credentials via first matching url and cleans the authentication data from the hosts urls before passing them to the ES client.

juliushaertl commented 1 year ago

Removing myself from review as its not really my area of expertise

R0Wi commented 1 year ago

@ArtificialOwl would it okay for you to merge this?

R0Wi commented 1 year ago

@ArtificialOwl any feedback please?

lukas-staab commented 1 year ago

Any chance this is merged soon? Like I understand it right now this non-merge is blocking the update to NC26 if basic auth is used. See also here https://github.com/nextcloud/fulltextsearch/issues/746. Support for NC25 ends in ~ 2 Months (https://endoflife.date/nextcloud)

brendan-pike commented 1 year ago

Just re-applied this to the latest release of fulltextsearch_elasticsearch 26.0.1 using elasticsearch 7.17.12 and it works well, please merge soon.

ArtificialOwl commented 1 year ago

/backport to stable27

ArtificialOwl commented 1 year ago

/backport to stable26